From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105956 invoked by alias); 23 Feb 2018 08:55:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105156 invoked by uid 89); 23 Feb 2018 08:55:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:896, H*r:sk:static. X-HELO: mail-wr0-f193.google.com Received: from mail-wr0-f193.google.com (HELO mail-wr0-f193.google.com) (209.85.128.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Feb 2018 08:55:34 +0000 Received: by mail-wr0-f193.google.com with SMTP id s5so13286832wra.0 for ; Fri, 23 Feb 2018 00:55:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5VBhRy6LrFPrLmXKtCh/dmV+etK4X1axk30DBXbBfsA=; b=tA2OvVnVZH1BMmu2G2WOavhjgB3dM5pXBrVWbgB/69+FD5EqLRrQZ/HTLfTvzNLj/P tdcIb9SrJ2GM0Oo4x4jZ8706VwtJcx4J+7DE9LQlO8IqqFuK0mp0S/9clfmpDL/JzLtN s5D2tQ0XWul5zZmvQsAKzYmx56Z5rrsLbCYzAbS9S1v9hlUWsvC2x0/LvEh7KUI+qYOh ckri+fA9DPw7KEhMB8ez96qWZHiuaaJRA/XyOJp7K1lBuNmxnJL9wylNzkfYbTcZDmKn P7+ns1KBRdy5Rslu76Wp7L26hqCnVE1dmgDO0OQiwFjIKvRkV4ZHmLqOHZsptYhuCAEY QkwQ== X-Gm-Message-State: APf1xPDIDmUkHcVDEyLJ0e7KID+a2eXodLxUhm7hrihXbennUC2me3ny +y+/o+ubAyPKfby/tBd0NbM= X-Google-Smtp-Source: AH8x227lYm8EO2sNS9tqGmK/cebFO/YyKigI7tsJP8zJflF+tZ4Fu2uw+wCeBZw7e/aJr3rvFGQ0fA== X-Received: by 10.223.138.251 with SMTP id z56mr864682wrz.196.1519376132048; Fri, 23 Feb 2018 00:55:32 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id u136sm1201460wmf.5.2018.02.23.00.55.30 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 23 Feb 2018 00:55:31 -0800 (PST) From: Yao Qi To: Xavier Roirand Cc: gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode References: <1519374774-13992-1-git-send-email-roirand@adacore.com> Date: Fri, 23 Feb 2018 08:55:00 -0000 In-Reply-To: <1519374774-13992-1-git-send-email-roirand@adacore.com> (Xavier Roirand's message of "Fri, 23 Feb 2018 09:32:54 +0100") Message-ID: <86h8q8hyps.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00336.txt.bz2 Xavier Roirand writes: Patch is good to me, some comments below, > +extern const struct language_defn ada_language_defn; > + > static int print_field_values (struct type *, const gdb_byte *, > int, > struct ui_file *, int, > @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type, > { > ada_val_print_1 (type, embedded_offset, address, > stream, recurse, val, options, > - current_language); > + &ada_language_defn); or we can use "language_def (language_ada)", so that we don't need to declare ada_language_defn above. > + > +gdb_test "bt" \ > + "#1 $hex in pck\\.call_me \\(s=3D\"test\"\\).*" \ > + "backtrace (auto: c)" Don't use "tail parentheses" on the test message, https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_pare= ntheses.22_on_test_messages --=20 Yao (=E9=BD=90=E5=B0=A7)