From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Xavier Roirand <roirand@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode
Date: Fri, 23 Feb 2018 09:37:00 -0000 [thread overview]
Message-ID: <20180223093710.lx2lds6u6qpbo5kf@adacore.com> (raw)
In-Reply-To: <86h8q8hyps.fsf@gmail.com>
> Patch is good to me, some comments below,
>
> > +extern const struct language_defn ada_language_defn;
> > +
> > static int print_field_values (struct type *, const gdb_byte *,
> > int,
> > struct ui_file *, int,
> > @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type,
> > {
> > ada_val_print_1 (type, embedded_offset, address,
> > stream, recurse, val, options,
> > - current_language);
> > + &ada_language_defn);
>
> or we can use "language_def (language_ada)", so that we don't need to
> declare ada_language_defn above.
I would prefer this as well - to remain consistent with what we do
elsewhere.
--
Joel
prev parent reply other threads:[~2018-02-23 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 8:33 Xavier Roirand
2018-02-23 8:55 ` Yao Qi
2018-02-23 9:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223093710.lx2lds6u6qpbo5kf@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=roirand@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox