From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121159 invoked by alias); 23 Feb 2018 09:37:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121147 invoked by uid 89); 23 Feb 2018 09:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Feb 2018 09:37:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E576A116A15; Fri, 23 Feb 2018 04:37:15 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4BP0CigpUCNJ; Fri, 23 Feb 2018 04:37:15 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7F2351169FD; Fri, 23 Feb 2018 04:37:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CF53F83054; Fri, 23 Feb 2018 13:37:10 +0400 (+04) Date: Fri, 23 Feb 2018 09:37:00 -0000 From: Joel Brobecker To: Yao Qi Cc: Xavier Roirand , gdb-patches@sourceware.org Subject: Re: [RFA v2] (Ada) Fix frame argument printing when using auto language mode Message-ID: <20180223093710.lx2lds6u6qpbo5kf@adacore.com> References: <1519374774-13992-1-git-send-email-roirand@adacore.com> <86h8q8hyps.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86h8q8hyps.fsf@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-02/txt/msg00337.txt.bz2 > Patch is good to me, some comments below, > > > +extern const struct language_defn ada_language_defn; > > + > > static int print_field_values (struct type *, const gdb_byte *, > > int, > > struct ui_file *, int, > > @@ -1208,7 +1210,7 @@ ada_val_print (struct type *type, > > { > > ada_val_print_1 (type, embedded_offset, address, > > stream, recurse, val, options, > > - current_language); > > + &ada_language_defn); > > or we can use "language_def (language_ada)", so that we don't need to > declare ada_language_defn above. I would prefer this as well - to remain consistent with what we do elsewhere. -- Joel