From: Yao Qi <qiyaoltc@gmail.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: palves@redhat.com, qiyaoltc@gmail.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V2 1/1] Fix of default lookup for "this" symbol.
Date: Fri, 01 Jul 2016 10:20:00 -0000 [thread overview]
Message-ID: <86eg7dzmm4.fsf@gmail.com> (raw)
In-Reply-To: <1467118304-31635-1-git-send-email-walfred.tedeschi@intel.com> (Walfred Tedeschi's message of "Tue, 28 Jun 2016 14:51:44 +0200")
Walfred Tedeschi <walfred.tedeschi@intel.com> writes:
> Tests: Performed tests with gfortran and ifort.
>
I assume you run all gdb testsuite rather than fortran tests only.
The patch is good to me if it is regression free with running all gdb
tests.
> 2016-06-16 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/ChangeLog:
>
> * cp-namespace.c (cp_lookup_bare_symbol): Add check for the
> name_of_this in order to return a null symbol when looking up
> for "this".
The entry doesn't reflect your change below. Please rewrite it.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-07-01 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 12:52 Walfred Tedeschi
2016-07-01 10:20 ` Yao Qi [this message]
2016-07-01 11:38 ` Tedeschi, Walfred
2016-07-01 12:38 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86eg7dzmm4.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox