RE: [PATCH V2 1/1] Fix of default lookup for "this" symbol.

Tedeschi, Walfred
2016-07-01T11:38:28Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1599 bytes --]

Yao,

Thanks for your review!

Yes I run all test suites. I was afraid that we could break other languages as weel.
However it was only 64bit tests, but all suites.

I will rewrite the entry for the Changelog. May I push then, or do you want to review it again?

Thanks and regards,
/Fred
PS: Sorry for top posting, I have to reconfigure my thunderbird.

-----Original Message-----
From: Yao Qi [mailto:qiyaoltc@gmail.com]
Sent: Friday, July 1, 2016 11:20 AM
To: Tedeschi, Walfred <walfred.tedeschi@intel.com>
Cc: palves@redhat.com; qiyaoltc@gmail.com; gdb-patches@sourceware.org
Subject: Re: [PATCH V2 1/1] Fix of default lookup for "this" symbol.

Walfred Tedeschi <walfred.tedeschi@intel.com> writes:

> Tests: Performed tests with gfortran and ifort.
>

I assume you run all gdb testsuite rather than fortran tests only.
The patch is good to me if it is regression free with running all gdb tests.

> 2016-06-16 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/ChangeLog:
>
> * cp-namespace.c (cp_lookup_bare_symbol): Add check for the
> name_of_this in order to return a null symbol when looking up
> for "this".

The entry doesn't reflect your change below. Please rewrite it.

--
Yao (é½å°§)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
\x16º&Öéj×!zÊÞ¶êç×}¸ÛÙb²Ö«r\x18\x1dn–­r\x17¬