From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113475 invoked by alias); 1 Jul 2016 10:20:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113463 invoked by uid 89); 1 Jul 2016 10:20:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:616 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 01 Jul 2016 10:19:55 +0000 Received: by mail-pa0-f47.google.com with SMTP id b13so37782040pat.0 for ; Fri, 01 Jul 2016 03:19:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SSDb9u9hkwFQHdERbmUFDelFF+vxhAkwIviNYgsxDok=; b=ICuxTS1UCxQVNJbgIOvYggIxNIYyt80t4+GXptTDjIs26govIEh/C0qcuevK4gzPaa qySGo5wG4KFXBPWS0qZX9psar2ITLIAw9LJhKHp0XUSTFcvfqIw4rPyeyLrDwSSGiEc9 h7mn1HYL8l1pP2NmAANBq88jHgXv0UPmp1jWQUbxGbgWx9m9t0dbBYY2h0b33WTAzkGX lT04lJrimENfqU5II1oK1m0cK1pYi3SFyqDsVgf0DKHYGC4vK5N13EsuvCbXjSYBqrmf caiyR1e75nVbkjbPHEfNwCFOuDk59HsxsFWadrS8ed+s0frVCQylmuFqNYUWHnxby55z 5ZqQ== X-Gm-Message-State: ALyK8tK+ZxpZRK4NqxRCgAo/D23cGmoDwcZhblaXn9O9OX3sL2WMRDZsbwlwVOnJ7jUT/A== X-Received: by 10.66.218.38 with SMTP id pd6mr29863808pac.13.1467368393829; Fri, 01 Jul 2016 03:19:53 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id n17sm4382020pfb.38.2016.07.01.03.19.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 01 Jul 2016 03:19:52 -0700 (PDT) From: Yao Qi To: Walfred Tedeschi Cc: palves@redhat.com, qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH V2 1/1] Fix of default lookup for "this" symbol. References: <1467118304-31635-1-git-send-email-walfred.tedeschi@intel.com> Date: Fri, 01 Jul 2016 10:20:00 -0000 In-Reply-To: <1467118304-31635-1-git-send-email-walfred.tedeschi@intel.com> (Walfred Tedeschi's message of "Tue, 28 Jun 2016 14:51:44 +0200") Message-ID: <86eg7dzmm4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00000.txt.bz2 Walfred Tedeschi writes: > Tests: Performed tests with gfortran and ifort. > I assume you run all gdb testsuite rather than fortran tests only. The patch is good to me if it is regression free with running all gdb tests. > 2016-06-16 Walfred Tedeschi > > gdb/ChangeLog: > > * cp-namespace.c (cp_lookup_bare_symbol): Add check for the > name_of_this in order to return a null symbol when looking up > for "this". The entry doesn't reflect your change below. Please rewrite it. --=20 Yao (=E9=BD=90=E5=B0=A7)