Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Schimpe, Christina" <christina.schimpe@intel.com>
Cc: gdb-patches@sourceware.org, felix.willgerodt@intel.com,
	luis.machado@arm.com
Subject: Re: [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints.
Date: Fri, 05 Jul 2024 13:47:27 +0300	[thread overview]
Message-ID: <86cyns6rpc.fsf@gnu.org> (raw)
In-Reply-To: <SN7PR11MB76383B27EF4382C237B600CAF9DF2@SN7PR11MB7638.namprd11.prod.outlook.com> (christina.schimpe@intel.com)

> From: "Schimpe, Christina" <christina.schimpe@intel.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, "Willgerodt,
>  Felix" <felix.willgerodt@intel.com>, "luis.machado@arm.com"
> 	<luis.machado@arm.com>
> Date: Fri, 5 Jul 2024 08:53:29 +0000
> 
> > > From: "Schimpe, Christina" <christina.schimpe@intel.com>
> > > CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
> > > "Willgerodt,  Felix" <felix.willgerodt@intel.com>, "luis.machado@arm.com"
> > > 	<luis.machado@arm.com>
> > > Date: Thu, 4 Jul 2024 13:15:20 +0000
> > >
> > > So to answer your question properly: No, we don't explain the term "
> > tagged data pointers" anywhere.
> > > But we write for instance in the commit message "tagged pointers used
> > > for data accesses", which is understandable I think.
> > 
> > Well, I'm sorry to say that it doesn't explain this enough for me.
> > I'm quite a heavy user of GDB, but I have no idea what is a tagged pointer for
> > data access.  Do we have in the manual anything related to such pointers,
> > even if we use different words to talk about them?  If so, could you point me
> > to those descriptions in the manual?  Maybe if I read what we say there, I
> > could suggest wording for NEWS that will be consistent with our terminology
> > in the manual.
> > 
> > Thanks.
> 
> Hi Eli, 
> 
> Sorry for the confusion here.
> You are right, the term "tagged pointer" is not explained anywhere in the manual. 
> Also I couldn't find a section that describes them but uses a different wording.
> 
> I think the first time we use this term in GDB is with commit
> "Clear non-significant bits of address on memory access".  
> The terms tagged address and tagged pointer are used.
> 
> A very similar commit for setting a  watchpoint on a tagged address but for AArch64 is:
> "Clear non-significant bits of address in watchpoint"
> 
> For both commits I couldn't find any documentation/NEWS part.
> 
> I will try to come up with a section on tagged addresses/pointers in the manual.

Thank you.

  reply	other threads:[~2024-07-05 10:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 10:17 [PATCH v4 0/2] Add amd64 LAM watchpoint support Schimpe, Christina
2024-07-04 10:17 ` [PATCH v4 1/2] gdb: Make tagged pointer support configurable Schimpe, Christina
2024-07-04 10:17 ` [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints Schimpe, Christina
2024-07-04 12:37   ` Willgerodt, Felix
2024-07-04 12:52   ` Eli Zaretskii
2024-07-04 13:05     ` Schimpe, Christina
2024-07-04 13:15       ` Schimpe, Christina
2024-07-04 14:06         ` Eli Zaretskii
2024-07-05  8:53           ` Schimpe, Christina
2024-07-05 10:47             ` Eli Zaretskii [this message]
2024-07-08  8:52               ` Schimpe, Christina
2024-07-08 11:42                 ` Eli Zaretskii
2024-07-08 14:25                   ` Schimpe, Christina
2024-07-08 14:53                     ` Eli Zaretskii
2024-07-08 14:57                       ` Schimpe, Christina
2024-07-04 14:02       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cyns6rpc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=christina.schimpe@intel.com \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox