From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vfo+D2LPh2b/XxwAWB0awg (envelope-from ) for ; Fri, 05 Jul 2024 06:48:02 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=H7xRqJkC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2719F1E0C3; Fri, 5 Jul 2024 06:48:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2597E1E097 for ; Fri, 5 Jul 2024 06:47:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A12F83884589 for ; Fri, 5 Jul 2024 10:47:58 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 8FBD23882656 for ; Fri, 5 Jul 2024 10:47:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FBD23882656 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FBD23882656 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720176457; cv=none; b=Jk1mA1GjZ/7cdq/jiQNm2WvQlQLIyuaZrI9O+mudNfjvAI6ZR6ZCmI57X7QixTzFom39uDhUmc9dmqlbyrU/PJ6Iu67G29KzGJO/4JoQsCZqwbFHi2qPdAVaKY6N7NFMaqBHBVvTuSdxc3n+ueW+MO9w0M82lGsDGw7d2U6lLGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720176457; c=relaxed/simple; bh=lGXVcdxtXM/TfgHLqH1+RHnCI0H1p8FU+c2tuUo5+zI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=PnbhiOUiiVqcMH6Z7vqfwIwt5B8M6u2uNSyvZjYKfu4peRJtq5FS5MTCm7fMdCr6ScMia8eKELq5PwdHcxziliHV55ap8EphDjmR9d0nGLYGaMLgfl8YdWkmfljkTIm+B4xLfQ59egxscM60llmqogluItiratm9nh1y+lRFuMc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPgTS-0000i9-Il; Fri, 05 Jul 2024 06:47:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bFmUBdkA5kPyipF+qVvtkuR7ArSp8qHk/R3CpNi61bs=; b=H7xRqJkC3SJV klXMTBurq3pm+dDVIVvoIbk35X85wCwVck9o4w0C+LOb3sW7Cy9uQHHlKz2aLJp9VFuALXqwgEXaL 8VEeTVgs9pBnUih2TXFV8N2YVhsUSCR+9yNz2HA/YUSOEfd7957FFmCQCJU/3bx8FD+dY0RzN2b50 enlcaPZoNRZ/soy3nDYjlkkmglkNaG6khgT/BLUgMNkJzxozWP+lskAS9/ORzIfJCte7fYhROc5eo MaDvUP/nRfBOBH+1q0X3d7rDeXAmlEGDlE+Y6yf7NXNWmiKycJgdw2JO6BpKOzdzHAugHZyaHusfz D8hCmpWvFfBjaWCu4XMRag==; Date: Fri, 05 Jul 2024 13:47:27 +0300 Message-Id: <86cyns6rpc.fsf@gnu.org> From: Eli Zaretskii To: "Schimpe, Christina" Cc: gdb-patches@sourceware.org, felix.willgerodt@intel.com, luis.machado@arm.com In-Reply-To: (christina.schimpe@intel.com) Subject: Re: [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints. References: <20240704101736.3074236-1-christina.schimpe@intel.com> <20240704101736.3074236-3-christina.schimpe@intel.com> <86tth58gk7.fsf@gnu.org> <86plrt8d5w.fsf@gnu.org> X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: "Schimpe, Christina" > CC: "gdb-patches@sourceware.org" , "Willgerodt, > Felix" , "luis.machado@arm.com" > > Date: Fri, 5 Jul 2024 08:53:29 +0000 > > > > From: "Schimpe, Christina" > > > CC: "gdb-patches@sourceware.org" , > > > "Willgerodt, Felix" , "luis.machado@arm.com" > > > > > > Date: Thu, 4 Jul 2024 13:15:20 +0000 > > > > > > So to answer your question properly: No, we don't explain the term " > > tagged data pointers" anywhere. > > > But we write for instance in the commit message "tagged pointers used > > > for data accesses", which is understandable I think. > > > > Well, I'm sorry to say that it doesn't explain this enough for me. > > I'm quite a heavy user of GDB, but I have no idea what is a tagged pointer for > > data access. Do we have in the manual anything related to such pointers, > > even if we use different words to talk about them? If so, could you point me > > to those descriptions in the manual? Maybe if I read what we say there, I > > could suggest wording for NEWS that will be consistent with our terminology > > in the manual. > > > > Thanks. > > Hi Eli, > > Sorry for the confusion here. > You are right, the term "tagged pointer" is not explained anywhere in the manual. > Also I couldn't find a section that describes them but uses a different wording. > > I think the first time we use this term in GDB is with commit > "Clear non-significant bits of address on memory access". > The terms tagged address and tagged pointer are used. > > A very similar commit for setting a watchpoint on a tagged address but for AArch64 is: > "Clear non-significant bits of address in watchpoint" > > For both commits I couldn't find any documentation/NEWS part. > > I will try to come up with a section on tagged addresses/pointers in the manual. Thank you.