From: "Schimpe, Christina" <christina.schimpe@intel.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Willgerodt, Felix" <felix.willgerodt@intel.com>,
"luis.machado@arm.com" <luis.machado@arm.com>
Subject: RE: [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints.
Date: Thu, 4 Jul 2024 13:05:35 +0000 [thread overview]
Message-ID: <SN7PR11MB763893D331E431FD5588B4F8F9DE2@SN7PR11MB7638.namprd11.prod.outlook.com> (raw)
In-Reply-To: <86tth58gk7.fsf@gnu.org>
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 47677cb773a..fcbb89e8bf8 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,8 @@
> >
> > *** Changes since GDB 15
> >
> > +* GDB now supports watchpoints for tagged data pointers on amd64.
> > +
> > * Debugger Adapter Protocol changes
>
> Thanks. The above NEWS text is okay, but I wonder whether we explain
> anywhere what are "tagged data pointers".
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Thanks for the review. I understand this can be a bit confusing.
Is " GDB now supports watchpoints for tagged pointers used for data accesses on amd64." better?
Or, we could also just write: " GDB now supports watchpoints for tagged pointers on amd64.", as watchpoints are usually just data breakpoints.
What do you think?
Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2024-07-04 13:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 10:17 [PATCH v4 0/2] Add amd64 LAM watchpoint support Schimpe, Christina
2024-07-04 10:17 ` [PATCH v4 1/2] gdb: Make tagged pointer support configurable Schimpe, Christina
2024-07-04 10:17 ` [PATCH v4 2/2] LAM: Enable tagged pointer support for watchpoints Schimpe, Christina
2024-07-04 12:37 ` Willgerodt, Felix
2024-07-04 12:52 ` Eli Zaretskii
2024-07-04 13:05 ` Schimpe, Christina [this message]
2024-07-04 13:15 ` Schimpe, Christina
2024-07-04 14:06 ` Eli Zaretskii
2024-07-05 8:53 ` Schimpe, Christina
2024-07-05 10:47 ` Eli Zaretskii
2024-07-08 8:52 ` Schimpe, Christina
2024-07-08 11:42 ` Eli Zaretskii
2024-07-08 14:25 ` Schimpe, Christina
2024-07-08 14:53 ` Eli Zaretskii
2024-07-08 14:57 ` Schimpe, Christina
2024-07-04 14:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB763893D331E431FD5588B4F8F9DE2@SN7PR11MB7638.namprd11.prod.outlook.com \
--to=christina.schimpe@intel.com \
--cc=eliz@gnu.org \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox