From: Yao Qi <qiyaoltc@gmail.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v6 4/7] Share regcache function regcache_raw_read_unsigned.
Date: Mon, 07 Dec 2015 14:40:00 -0000 [thread overview]
Message-ID: <86bna2s4ok.fsf@gmail.com> (raw)
In-Reply-To: <1449254773-19019-5-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Fri, 4 Dec 2015 13:46:10 -0500")
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> gdb/ChangeLog:
> * Makefile.in: Add common-regcache.c/.o.
Need to describe what do we change in Makefile.in, like
* Makefile.in (SFILES): Append common/common-regcache.c.
(COMMON_OBS): Append common/common-regcache.o.
(common-regcache.o): New rule.
> * common/common-regcache.h (register_status) New enum.
> (regcache_raw_read_unsigned): New declaration.
> * common/common-regcache.c: New file.
> * regcache.h (enum register_status): Move to common-regcache.h.
> (regcache_raw_read_unsigned): Likewise.
> (regcache_raw_get_unsigned): Likewise.
>
> gdb/gdbserver/ChangeLog:
>
> * Makefile.in: Add common-regcache.c/.o.
Likewise.
> * regcache.c (init_register_cache): Initialize cache to
> REG_UNAVAILABLE.
> (regcache_raw_read_unsigned): New function.
> * regcache.h (REG_UNAVAILABLE, REG_VALID): Replaced by shared
> register_status enum.
Patch is good to me, otherwise.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-12-07 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 18:46 [PATCH v6 0/6] Support software single step and conditional breakpoints on ARM in GDBServer Antoine Tremblay
2015-12-04 18:46 ` [PATCH v6 4/7] Share regcache function regcache_raw_read_unsigned Antoine Tremblay
2015-12-07 14:40 ` Yao Qi [this message]
2015-12-07 14:49 ` Antoine Tremblay
2015-12-04 18:46 ` [PATCH v6 2/7] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-04 18:46 ` [PATCH v6 3/7] Refactor arm_software_single_step to use regcache Antoine Tremblay
2015-12-07 14:32 ` Yao Qi
2015-12-07 14:48 ` Antoine Tremblay
2015-12-07 15:21 ` Yao Qi
2015-12-07 17:37 ` Antoine Tremblay
2015-12-07 14:51 ` Yao Qi
2015-12-07 14:51 ` Antoine Tremblay
2015-12-04 18:46 ` [PATCH v6 1/7] Replace breakpoint_reinsert_addr by get_next_pcs operation in GDBServer Antoine Tremblay
2015-12-04 18:47 ` [PATCH v6 5/7] Support software single step on ARM " Antoine Tremblay
2015-12-07 15:18 ` Yao Qi
2015-12-07 15:58 ` Antoine Tremblay
2015-12-04 18:47 ` [PATCH v6 6/7] Enable software single stepping for while-stepping actions " Antoine Tremblay
2015-12-04 18:47 ` [PATCH v6 7/7] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bna2s4ok.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox