From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4961 invoked by alias); 7 Dec 2015 14:40:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4947 invoked by uid 89); 7 Dec 2015 14:40:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 07 Dec 2015 14:40:20 +0000 Received: by pacwq6 with SMTP id wq6so48620542pac.1 for ; Mon, 07 Dec 2015 06:40:18 -0800 (PST) X-Received: by 10.66.150.37 with SMTP id uf5mr44311818pab.30.1449499218201; Mon, 07 Dec 2015 06:40:18 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id wi3sm9543187pab.2.2015.12.07.06.40.16 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 07 Dec 2015 06:40:17 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v6 4/7] Share regcache function regcache_raw_read_unsigned. References: <1449254773-19019-1-git-send-email-antoine.tremblay@ericsson.com> <1449254773-19019-5-git-send-email-antoine.tremblay@ericsson.com> Date: Mon, 07 Dec 2015 14:40:00 -0000 In-Reply-To: <1449254773-19019-5-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Fri, 4 Dec 2015 13:46:10 -0500") Message-ID: <86bna2s4ok.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00131.txt.bz2 Antoine Tremblay writes: > gdb/ChangeLog: > * Makefile.in: Add common-regcache.c/.o. Need to describe what do we change in Makefile.in, like * Makefile.in (SFILES): Append common/common-regcache.c. (COMMON_OBS): Append common/common-regcache.o. (common-regcache.o): New rule. > * common/common-regcache.h (register_status) New enum. > (regcache_raw_read_unsigned): New declaration. > * common/common-regcache.c: New file. > * regcache.h (enum register_status): Move to common-regcache.h. > (regcache_raw_read_unsigned): Likewise. > (regcache_raw_get_unsigned): Likewise. > > gdb/gdbserver/ChangeLog: > > * Makefile.in: Add common-regcache.c/.o. Likewise. > * regcache.c (init_register_cache): Initialize cache to > REG_UNAVAILABLE. > (regcache_raw_read_unsigned): New function. > * regcache.h (REG_UNAVAILABLE, REG_VALID): Replaced by shared > register_status enum. Patch is good to me, otherwise. --=20 Yao (=E9=BD=90=E5=B0=A7)