From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 7/8] Use reinsert_breakpoint for vCont;s
Date: Thu, 26 May 2016 16:52:00 -0000 [thread overview]
Message-ID: <868tyw4v8k.fsf@gmail.com> (raw)
In-Reply-To: <1fe2e4c5-88c5-e7ec-4d8c-4ba6849ab7ba@redhat.com> (Pedro Alves's message of "Tue, 24 May 2016 18:38:51 +0100")
Pedro Alves <palves@redhat.com> writes:
>> + /* Remove reinsert breakpoints for resume_step. */
>> + if (can_software_single_step ()
>> + && current_thread->last_resume_kind == resume_step
>
> What if a vCont;t came in after the step had started and
> before it finished? Won't we have lost the resume_step
> linux_set_resume_request then?
Do you mean a case like this? GDB sends vCont;s, and then GDBserver
started step-over, in the middle of step-over, GDB sends vCont;t, so
thread->last_resume_kind is set from resume_step to resume_stop, and the
check here fails, so reinsert breakpoints are not deleted.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-05-26 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 15:12 [PATCH 0/8] Use reinsert breakpoint " Yao Qi
2016-05-20 15:13 ` [PATCH 8/8] [GDBserver] Support vCont s and S actions with software single step Yao Qi
2016-05-24 17:41 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 5/8] Refactor clone_all_breakpoints Yao Qi
2016-05-24 16:27 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 1/8] Switch to current thread before finish_step_over Yao Qi
2016-05-24 15:59 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 2/8] Delete reinsert breakpoints from forked child Yao Qi
2016-05-24 16:06 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 7/8] Use reinsert_breakpoint for vCont;s Yao Qi
2016-05-24 17:39 ` Pedro Alves
2016-05-26 16:52 ` Yao Qi [this message]
2016-05-26 17:00 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 3/8] Pass breakpoint type in set_breakpoint_at Yao Qi
2016-05-24 16:10 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 4/8] Create sub classes of 'struct breakpoint' Yao Qi
2016-05-24 16:23 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 6/8] Make reinsert_breakpoint thread specific Yao Qi
2016-05-24 16:39 ` Pedro Alves
2016-05-24 15:08 ` [PATCH 0/8] Use reinsert breakpoint for vCont;s Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868tyw4v8k.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox