From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103470 invoked by alias); 26 May 2016 16:52:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103442 invoked by uid 89); 26 May 2016 16:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f173.google.com Received: from mail-pf0-f173.google.com (HELO mail-pf0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 26 May 2016 16:52:50 +0000 Received: by mail-pf0-f173.google.com with SMTP id y69so32550632pfb.1 for ; Thu, 26 May 2016 09:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hhMJwAUvct1iByAoGvbT1kdFv7fskzvcpf1guiPyjZY=; b=Pl2wYe9HXObKMbclOqpsRipzkvrpx8Elz22MkcX351l2fXjePtaCEcf2X5olVqxgkb uVUQTIczvFBoTh6ko/EZ/u/tfhVrQXVjpE/t7qRXTcAuJLOV+OaWqonwuZgWIHuHRA54 hgexj5JyFK/+4/YsgVFbqstQGfq5RiXMPHN6JdaIhx+yAWPBT+ro2yLhUR9Blu5R6tO4 INgyfJAeyOn5hVgMHxeMm1sOrMXk7wI/p93nJAl5orhGpdvW/cWtljCVKdVCRxE8LuDf gRnpNXl3vCstXmcX5vE7/J6OQguNMjTGVF33mrHFswz4RNkRK253AbKgytATLnhgzFF4 Ko7A== X-Gm-Message-State: ALyK8tLOS9L9LY3ASdu8qSILZlVbapEbCvbMXumaAgaaGid0decbmAX6hRfhiJ49p4BqRQ== X-Received: by 10.98.93.7 with SMTP id r7mr15661253pfb.66.1464281569073; Thu, 26 May 2016 09:52:49 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id p15sm7330819pfi.67.2016.05.26.09.52.46 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 26 May 2016 09:52:48 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 7/8] Use reinsert_breakpoint for vCont;s References: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> <1463757161-25850-8-git-send-email-yao.qi@linaro.org> <1fe2e4c5-88c5-e7ec-4d8c-4ba6849ab7ba@redhat.com> Date: Thu, 26 May 2016 16:52:00 -0000 In-Reply-To: <1fe2e4c5-88c5-e7ec-4d8c-4ba6849ab7ba@redhat.com> (Pedro Alves's message of "Tue, 24 May 2016 18:38:51 +0100") Message-ID: <868tyw4v8k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00460.txt.bz2 Pedro Alves writes: >> + /* Remove reinsert breakpoints for resume_step. */ >> + if (can_software_single_step () >> + && current_thread->last_resume_kind =3D=3D resume_step > > What if a vCont;t came in after the step had started and > before it finished? Won't we have lost the resume_step=20 > linux_set_resume_request then? Do you mean a case like this? GDB sends vCont;s, and then GDBserver started step-over, in the middle of step-over, GDB sends vCont;t, so thread->last_resume_kind is set from resume_step to resume_stop, and the check here fails, so reinsert breakpoints are not deleted. --=20 Yao (=E9=BD=90=E5=B0=A7)