From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/8] Create sub classes of 'struct breakpoint'
Date: Tue, 24 May 2016 16:23:00 -0000 [thread overview]
Message-ID: <019cfcb1-129b-617e-e422-c86babebc2fd@redhat.com> (raw)
In-Reply-To: <1463757161-25850-5-git-send-email-yao.qi@linaro.org>
On 05/20/2016 04:12 PM, Yao Qi wrote:
> Nowadays, there are three types of breakpoint in GDBserver,
>
> - gdb breakpoints,
> - reinsert breakpoints, used for software single step,
> - other breakpoints, used for tracepoint,
We should probably rename the latter two, so we didn't
have to explain what they are. (Doesn't have to be
in this patch, but it's true this patch exposes the naming
to even more places...)
Anyway, LGTM.
The clone_one_breakpoint changes are calling for src->vtable->clone(); :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-24 16:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 15:12 [PATCH 0/8] Use reinsert breakpoint for vCont;s Yao Qi
2016-05-20 15:13 ` [PATCH 3/8] Pass breakpoint type in set_breakpoint_at Yao Qi
2016-05-24 16:10 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 4/8] Create sub classes of 'struct breakpoint' Yao Qi
2016-05-24 16:23 ` Pedro Alves [this message]
2016-05-20 15:13 ` [PATCH 6/8] Make reinsert_breakpoint thread specific Yao Qi
2016-05-24 16:39 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 8/8] [GDBserver] Support vCont s and S actions with software single step Yao Qi
2016-05-24 17:41 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 5/8] Refactor clone_all_breakpoints Yao Qi
2016-05-24 16:27 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 1/8] Switch to current thread before finish_step_over Yao Qi
2016-05-24 15:59 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 2/8] Delete reinsert breakpoints from forked child Yao Qi
2016-05-24 16:06 ` Pedro Alves
2016-05-20 15:13 ` [PATCH 7/8] Use reinsert_breakpoint for vCont;s Yao Qi
2016-05-24 17:39 ` Pedro Alves
2016-05-26 16:52 ` Yao Qi
2016-05-26 17:00 ` Pedro Alves
2016-05-24 15:08 ` [PATCH 0/8] Use reinsert breakpoint " Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=019cfcb1-129b-617e-e422-c86babebc2fd@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox