From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77069 invoked by alias); 24 May 2016 16:23:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76670 invoked by uid 89); 24 May 2016 16:23:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:585 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 May 2016 16:23:28 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F68DC0035A0; Tue, 24 May 2016 16:23:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4OGNQBq009663; Tue, 24 May 2016 12:23:26 -0400 Subject: Re: [PATCH 4/8] Create sub classes of 'struct breakpoint' To: Yao Qi , gdb-patches@sourceware.org References: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> <1463757161-25850-5-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <019cfcb1-129b-617e-e422-c86babebc2fd@redhat.com> Date: Tue, 24 May 2016 16:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463757161-25850-5-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00429.txt.bz2 On 05/20/2016 04:12 PM, Yao Qi wrote: > Nowadays, there are three types of breakpoint in GDBserver, > > - gdb breakpoints, > - reinsert breakpoints, used for software single step, > - other breakpoints, used for tracepoint, We should probably rename the latter two, so we didn't have to explain what they are. (Doesn't have to be in this patch, but it's true this patch exposes the naming to even more places...) Anyway, LGTM. The clone_one_breakpoint changes are calling for src->vtable->clone(); :-) Thanks, Pedro Alves