From: Yao Qi <qiyaoltc@gmail.com>
To: tbsaunde+binutils@tbsaunde.org
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, committed] remove trivialy unused variables
Date: Mon, 09 May 2016 07:51:00 -0000 [thread overview]
Message-ID: <8660und5zq.fsf@gmail.com> (raw)
In-Reply-To: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> (tbsaunde's message of "Sat, 7 May 2016 20:14:24 -0400")
tbsaunde+binutils@tbsaunde.org writes:
> diff --git a/gdb/linespec.c b/gdb/linespec.c
> index 2360cc1..c0c3b3b3 100644
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -845,8 +845,6 @@ add_sal_to_sals (struct linespec_state *self,
> canonical = &self->canonical_names[sals->nelts - 1];
> if (!literal_canonical && sal->symtab)
> {
> - const char *fullname = symtab_to_fullname (sal->symtab);
> -
Variable fullname isn't used, but I am not sure we can remove the call
to symtab_to_fullname. At least, symtab_to_fullname sets
sal->symtab->fullname, and we have this some lines below,
canonical->symtab = sal->symtab;
--
Yao (齐尧)
next prev parent reply other threads:[~2016-05-09 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 0:10 tbsaunde+binutils
2016-05-09 7:38 ` Yao Qi
2016-05-10 1:07 ` Trevor Saunders
2016-05-09 7:51 ` Yao Qi [this message]
2016-05-10 3:35 ` Trevor Saunders
2016-05-10 7:13 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8660und5zq.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tbsaunde+binutils@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox