From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62397 invoked by alias); 9 May 2016 07:51:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62365 invoked by uid 89); 9 May 2016 07:51:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f171.google.com Received: from mail-pf0-f171.google.com (HELO mail-pf0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 09 May 2016 07:51:21 +0000 Received: by mail-pf0-f171.google.com with SMTP id y69so72640839pfb.1 for ; Mon, 09 May 2016 00:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yhVGCr199iGP3aTPmaiSEaiJ1vmr31wtk5GMIHcdVl4=; b=MpZOdJaDo4Y3b+WNaRML9Ns7uGsEdRTdBPXFS+McqucRJqRPlPEgd2gazMDSi+GGPA I5QhLdNu3I2mKuExFUG526MNIwTjqgbrFU9Becy1ixn2X5hzJ6/45ORAiWnWYuuW332X iD/HphkDrVRZH+GBDBFEtrGj7OPN9AdxQPfmbmJLRJr0KQbjndKY3cjB4tF67m7M7iJI pECLMiNww9W1mJiJhJJl8DOE2xOqD+TzQU7xuBt8QrUICHFZb/710QU3XwperSiY3Jhj G+xk1sDwXV18EOKTI2vTYlTW0X/7E7fCNg2KFsSKRdtm4doimV0XU+NFOUsRplj+b2cL ISzQ== X-Gm-Message-State: AOPr4FW6m39h8mphcFO7/bXKYG3H+XGR+qRWxmJxpRLcymIf3iv66w/LBMix28xscjJdrw== X-Received: by 10.98.69.132 with SMTP id n4mr47794877pfi.53.1462780279979; Mon, 09 May 2016 00:51:19 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id o63sm38203976pfj.30.2016.05.09.00.51.18 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 09 May 2016 00:51:19 -0700 (PDT) From: Yao Qi To: tbsaunde+binutils@tbsaunde.org Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, committed] remove trivialy unused variables References: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> Date: Mon, 09 May 2016 07:51:00 -0000 In-Reply-To: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> (tbsaunde's message of "Sat, 7 May 2016 20:14:24 -0400") Message-ID: <8660und5zq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00140.txt.bz2 tbsaunde+binutils@tbsaunde.org writes: > diff --git a/gdb/linespec.c b/gdb/linespec.c > index 2360cc1..c0c3b3b3 100644 > --- a/gdb/linespec.c > +++ b/gdb/linespec.c > @@ -845,8 +845,6 @@ add_sal_to_sals (struct linespec_state *self, > canonical =3D &self->canonical_names[sals->nelts - 1]; > if (!literal_canonical && sal->symtab) > { > - const char *fullname =3D symtab_to_fullname (sal->symtab); > - Variable fullname isn't used, but I am not sure we can remove the call to symtab_to_fullname. At least, symtab_to_fullname sets sal->symtab->fullname, and we have this some lines below, canonical->symtab =3D sal->symtab; --=20 Yao (=E9=BD=90=E5=B0=A7)