From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: tbsaunde+binutils@tbsaunde.org, gdb-patches@sourceware.org
Subject: Re: [PATCH, committed] remove trivialy unused variables
Date: Tue, 10 May 2016 01:07:00 -0000 [thread overview]
Message-ID: <20160510005056.GA19966@ball> (raw)
In-Reply-To: <86a8jzd6ku.fsf@gmail.com>
On Mon, May 09, 2016 at 08:38:25AM +0100, Yao Qi wrote:
> tbsaunde+binutils@tbsaunde.org writes:
>
> > @@ -206,8 +206,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> > struct symtab_and_line sal;
> > CORE_ADDR pc;
> > CORE_ADDR loop_end;
> > - int found_store_lr = 0;
> > - int found_decr_sp = 0;
> > int srcreg;
> > int tgtreg;
> > signed short offset;
> > @@ -251,7 +249,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> > cache->saved_regs[tgtreg] = -((signed short) (insn & 0xffff));
> >
> > if (tgtreg == E_LR_REGNUM)
> > - found_store_lr = 1;
>
> We should remove line "if (tgtreg == E_LR_REGNUM)" as well, otherwise,
> the code behavior is changed.
ouch, not sure how me and Pedro both missed that :( I'll send a fix
tonight.
Trev
>
> > continue;
> > }
> >
>
> --
> Yao (é½å°§)
next prev parent reply other threads:[~2016-05-10 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 0:10 tbsaunde+binutils
2016-05-09 7:38 ` Yao Qi
2016-05-10 1:07 ` Trevor Saunders [this message]
2016-05-09 7:51 ` Yao Qi
2016-05-10 3:35 ` Trevor Saunders
2016-05-10 7:13 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510005056.GA19966@ball \
--to=tbsaunde@tbsaunde.org \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=tbsaunde+binutils@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox