From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131449-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 86215 invoked by alias); 10 May 2016 01:07:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 86163 invoked by uid 89); 10 May 2016 01:07:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=tonight, H*r:sk:papercl, HX-HELO:sk:papercl, H*RU:sk:papercl
X-HELO: paperclip.tbsaunde.org
Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 May 2016 01:07:24 +0000
Received: from ball (unknown [IPv6:2607:f0c8:8000:80e0:56ee:75ff:fe52:afb9])	by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 89F45C0C4;	Tue, 10 May 2016 01:07:22 +0000 (UTC)
Date: Tue, 10 May 2016 01:07:00 -0000
From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: tbsaunde+binutils@tbsaunde.org, gdb-patches@sourceware.org
Subject: Re: [PATCH, committed] remove trivialy unused variables
Message-ID: <20160510005056.GA19966@ball>
References: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> <86a8jzd6ku.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86a8jzd6ku.fsf@gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SW-Source: 2016-05/txt/msg00155.txt.bz2

On Mon, May 09, 2016 at 08:38:25AM +0100, Yao Qi wrote:
> tbsaunde+binutils@tbsaunde.org writes:
> 
> > @@ -206,8 +206,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> >    struct symtab_and_line sal;
> >    CORE_ADDR pc;
> >    CORE_ADDR loop_end;
> > -  int found_store_lr = 0;
> > -  int found_decr_sp = 0;
> >    int srcreg;
> >    int tgtreg;
> >    signed short offset;
> > @@ -251,7 +249,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch,
> >  	    cache->saved_regs[tgtreg] = -((signed short) (insn & 0xffff));
> >  
> >  	  if (tgtreg == E_LR_REGNUM)
> > -	    found_store_lr = 1;
> 
> We should remove line "if (tgtreg == E_LR_REGNUM)" as well, otherwise,
> the code behavior is changed.

ouch, not sure how me and Pedro both missed that :(  I'll send a  fix
tonight.

Trev

> 
> >  	  continue;
> >  	}
> >  
> 
> -- 
> Yao (齐尧)