From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn
Date: Thu, 11 Feb 2016 10:54:00 -0000 [thread overview]
Message-ID: <861t8jqzz2.fsf@gmail.com> (raw)
In-Reply-To: <1455128356-4483-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 10 Feb 2016 13:19:15 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
> This function is never used, since it is superseded by
> arm_linux_displaced_step_copy_insn.
>
> gdb/ChangeLog:
>
> * arm-tdep.c (arm_displaced_step_copy_insn): Remove.
> * arm-tdep.h (arm_displaced_step_copy_insn): Remove.
arm_displaced_step_copy_insn is still referenced in the comments in
arm-linux-tdep.c,
/* Linux-specific displaced step instruction copying function. Detects when
the program has stepped into a Linux kernel helper routine (which must be
handled as a special case), falling back to arm_displaced_step_copy_insn()
if it hasn't. */
Can you remove it from the comments as well? These comments can be
simplified further like
/* Implement the "displaced_step_copy_insn" gdbarch method. */
OK with the change like this.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-02-11 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 18:19 Simon Marchi
2016-02-10 18:19 ` [PATCH 2/2] arm-tdep.c: Remove unused variables Simon Marchi
2016-02-11 12:10 ` Yao Qi
2016-02-11 10:54 ` Yao Qi [this message]
2016-02-11 19:15 ` [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861t8jqzz2.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox