From: Simon Marchi <simon.marchi@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn
Date: Thu, 11 Feb 2016 19:15:00 -0000 [thread overview]
Message-ID: <56BCDDB1.6000301@ericsson.com> (raw)
In-Reply-To: <861t8jqzz2.fsf@gmail.com>
On 16-02-11 05:54 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> This function is never used, since it is superseded by
>> arm_linux_displaced_step_copy_insn.
>>
>> gdb/ChangeLog:
>>
>> * arm-tdep.c (arm_displaced_step_copy_insn): Remove.
>> * arm-tdep.h (arm_displaced_step_copy_insn): Remove.
>
> arm_displaced_step_copy_insn is still referenced in the comments in
> arm-linux-tdep.c,
>
> /* Linux-specific displaced step instruction copying function. Detects when
> the program has stepped into a Linux kernel helper routine (which must be
> handled as a special case), falling back to arm_displaced_step_copy_insn()
> if it hasn't. */
>
> Can you remove it from the comments as well? These comments can be
> simplified further like
>
> /* Implement the "displaced_step_copy_insn" gdbarch method. */
>
> OK with the change like this.
>
Thanks, both patches pushed, with the change in this one.
prev parent reply other threads:[~2016-02-11 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 18:19 Simon Marchi
2016-02-10 18:19 ` [PATCH 2/2] arm-tdep.c: Remove unused variables Simon Marchi
2016-02-11 12:10 ` Yao Qi
2016-02-11 10:54 ` [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn Yao Qi
2016-02-11 19:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCDDB1.6000301@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox