From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-129502-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31110 invoked by alias); 11 Feb 2016 19:15:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30962 invoked by uid 89); 11 Feb 2016 19:15:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=displaced
X-HELO: usplmg21.ericsson.net
Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Feb 2016 19:15:00 +0000
Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90])	by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 09.B6.32102.B9DDCB65; Thu, 11 Feb 2016 20:14:36 +0100 (CET)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.92) with Microsoft SMTP Server id 14.3.248.2; Thu, 11 Feb 2016 14:14:57 -0500
Subject: Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn
To: Yao Qi <qiyaoltc@gmail.com>
References: <1455128356-4483-1-git-send-email-simon.marchi@ericsson.com> <861t8jqzz2.fsf@gmail.com>
CC: <gdb-patches@sourceware.org>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <56BCDDB1.6000301@ericsson.com>
Date: Thu, 11 Feb 2016 19:15:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <861t8jqzz2.fsf@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-02/txt/msg00386.txt.bz2

On 16-02-11 05:54 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>> This function is never used, since it is superseded by
>> arm_linux_displaced_step_copy_insn.
>>
>> gdb/ChangeLog:
>>
>> 	* arm-tdep.c (arm_displaced_step_copy_insn): Remove.
>> 	* arm-tdep.h (arm_displaced_step_copy_insn): Remove.
> 
> arm_displaced_step_copy_insn is still referenced in the comments in
> arm-linux-tdep.c,
> 
> /* Linux-specific displaced step instruction copying function.  Detects when
>    the program has stepped into a Linux kernel helper routine (which must be
>    handled as a special case), falling back to arm_displaced_step_copy_insn()
>    if it hasn't.  */
> 
> Can you remove it from the comments as well?  These comments can be
> simplified further like
> 
> /* Implement the "displaced_step_copy_insn" gdbarch method.  */
> 
> OK with the change like this.
> 

Thanks, both patches pushed, with the change in this one.