From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89996 invoked by alias); 11 Feb 2016 10:54:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89986 invoked by uid 89); 11 Feb 2016 10:54:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=stepped, Hx-spam-relays-external:209.85.220.67, H*RU:209.85.220.67, displaced X-HELO: mail-pa0-f67.google.com Received: from mail-pa0-f67.google.com (HELO mail-pa0-f67.google.com) (209.85.220.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 10:54:31 +0000 Received: by mail-pa0-f67.google.com with SMTP id fl4so2276622pad.2 for ; Thu, 11 Feb 2016 02:54:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=A5ltzj6Lmk1g00UzFnxzNo4fkspAmNgAgMdKtzyvL5M=; b=WbxvV4+u4DEm8aHPNLAzmgn2nVXIsuHOYWqRBx3wvU4zrGafQfuP405AomZtP0Q7WZ hWZzmkfXo4pqmEqJO/0mmjDJUkCPgAwduY6mFsU8k2nDFohnuXIC9aioiVgGr9fPhLky FyRo37KkKtzPoZM3cp9YnMIMHt4MSsHQG/K7mHfABFvW1GfNlnBjB6xH9+UcBzQlBLuJ 3MhZWiS5fwq9+zrQ0sg0wqoRRjcKK+d75fPn5f4R7uRQrR8zTFoauQZr7zx0YK2hdeV4 AbrB1Yv5E0ODo/rciszZTEnz/8m4nawDVxRlMB1q1BuGBPTY2ttZeXnDF3oDLOGuHDVP iGVA== X-Gm-Message-State: AG10YOR9MR2mRzZa+8XWlkOOFSRyP0kUlRTZXIAduO9dk1KfBZVREv3JheExYllJBnqAZg== X-Received: by 10.67.7.42 with SMTP id cz10mr50968555pad.158.1455188069789; Thu, 11 Feb 2016 02:54:29 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id wh9sm11466796pab.8.2016.02.11.02.54.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 11 Feb 2016 02:54:28 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn References: <1455128356-4483-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 11 Feb 2016 10:54:00 -0000 In-Reply-To: <1455128356-4483-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 10 Feb 2016 13:19:15 -0500") Message-ID: <861t8jqzz2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00337.txt.bz2 Simon Marchi writes: > This function is never used, since it is superseded by > arm_linux_displaced_step_copy_insn. > > gdb/ChangeLog: > > * arm-tdep.c (arm_displaced_step_copy_insn): Remove. > * arm-tdep.h (arm_displaced_step_copy_insn): Remove. arm_displaced_step_copy_insn is still referenced in the comments in arm-linux-tdep.c, /* Linux-specific displaced step instruction copying function. Detects when the program has stepped into a Linux kernel helper routine (which must be handled as a special case), falling back to arm_displaced_step_copy_insn= () if it hasn't. */ Can you remove it from the comments as well? These comments can be simplified further like /* Implement the "displaced_step_copy_insn" gdbarch method. */ OK with the change like this. --=20 Yao (=E9=BD=90=E5=B0=A7)