From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix corefile-buildid.exp with check-read1
Date: Wed, 19 Feb 2020 20:09:00 -0000 [thread overview]
Message-ID: <851a18b0-b172-4b59-e411-ce3379c95c76@redhat.com> (raw)
In-Reply-To: <20200219174014.GA28126@delia>
On 2/19/20 5:40 PM, Tom de Vries wrote:
> Hi,
>
> When running gdb.base/corefile-buildid.exp using check-read1, I run into:
> ...
> FAIL: gdb.base/corefile-buildid.exp: shared: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files \
> (timeout)
> ...
>
> This is caused by attempting to match the output of an "info files" command
> using a single gdb_test in check_exec_file.
>
> Fix this by doing line-by-line matching in check_exec_file.
>
> Tested on x86_64-linux, using make targets check and check-read1.
>
> OK for trunk?
OK.
If this pattern appears in more places it may be worth it to
think about some abstraction to make it easier to write.
Like e.g., a new "-lbl" (line-by-line) option switch to
gdb_test_multiple that auto-appends the "match one line" regexp.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-02-19 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:40 Tom de Vries
2020-02-19 20:09 ` Pedro Alves [this message]
2020-02-19 21:30 ` [RFC][gdb/testsuite] Handle -line and -non-empty-line in gdb_test_multiple Tom de Vries
2020-02-20 13:28 ` Pedro Alves
2020-02-21 15:35 ` [RFC][gdb/testsuite] Add -lbl option " Tom de Vries
2020-02-27 16:03 ` Pedro Alves
2020-03-01 9:08 ` Tom de Vries
2020-03-02 13:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851a18b0-b172-4b59-e411-ce3379c95c76@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox