From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix corefile-buildid.exp with check-read1
Date: Wed, 19 Feb 2020 17:40:00 -0000 [thread overview]
Message-ID: <20200219174014.GA28126@delia> (raw)
Hi,
When running gdb.base/corefile-buildid.exp using check-read1, I run into:
...
FAIL: gdb.base/corefile-buildid.exp: shared: info files (timeout)
FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files (timeout)
FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files (timeout)
FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files \
(timeout)
...
This is caused by attempting to match the output of an "info files" command
using a single gdb_test in check_exec_file.
Fix this by doing line-by-line matching in check_exec_file.
Tested on x86_64-linux, using make targets check and check-read1.
OK for trunk?
Thanks,
- Tom
[gdb/testsuite] Fix corefile-buildid.exp with check-read1
gdb/testsuite/ChangeLog:
2020-02-19 Tom de Vries <tdevries@suse.de>
* gdb.base/corefile-buildid.exp (check_exec_file): Match info files
output line-by-line.
---
gdb/testsuite/gdb.base/corefile-buildid.exp | 49 ++++++++++++++++++++++++++++-
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp
index 158cbb6dc6..b9844ee354 100644
--- a/gdb/testsuite/gdb.base/corefile-buildid.exp
+++ b/gdb/testsuite/gdb.base/corefile-buildid.exp
@@ -108,8 +108,55 @@ proc append_debug_dir {debugdir} {
# FILE.
proc check_exec_file {file} {
+ global gdb_prompt
send_log "expecting exec file \"$file\"\n"
- gdb_test "info files" "Local exec file:\[\r\n\t\ \]+`[string_to_regexp $file]'.*"
+
+ # Get line with "Local exec file:".
+ set ok 0
+ gdb_test_multiple "info files" "" {
+ -re "^Local exec file:\r\n" {
+ set test_name $gdb_test_name
+ set ok 1
+ }
+ -re "^$gdb_prompt $" {
+ fail $gdb_test_name
+ }
+ -re "^\[^\r\n\]*\r\n" {
+ exp_continue
+ }
+ }
+
+ if { $ok == 0 } {
+ return
+ }
+
+ # Get subsequent line with $file.
+ set ok 0
+ gdb_test_multiple "" $test_name {
+ -re "^\[\t\ \]+`[string_to_regexp $file]'\[^\r\n\]*\r\n" {
+ set ok 1
+ }
+ -re "^$gdb_prompt $" {
+ fail $gdb_test_name
+ }
+ -re "^\[^\r\n\]*\r\n" {
+ exp_continue
+ }
+ }
+
+ if { $ok == 0 } {
+ return
+ }
+
+ # Skip till prompt.
+ gdb_test_multiple "" $test_name {
+ -re "^$gdb_prompt $" {
+ pass $gdb_test_name
+ }
+ -re "^\[^\r\n\]*\r\n" {
+ exp_continue
+ }
+ }
}
# Test whether gdb can find an exec file from a core file's build-id.
next reply other threads:[~2020-02-19 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:40 Tom de Vries [this message]
2020-02-19 20:09 ` Pedro Alves
2020-02-19 21:30 ` [RFC][gdb/testsuite] Handle -line and -non-empty-line in gdb_test_multiple Tom de Vries
2020-02-20 13:28 ` Pedro Alves
2020-02-21 15:35 ` [RFC][gdb/testsuite] Add -lbl option " Tom de Vries
2020-02-27 16:03 ` Pedro Alves
2020-03-01 9:08 ` Tom de Vries
2020-03-02 13:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219174014.GA28126@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox