From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96825 invoked by alias); 19 Feb 2020 20:09:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96812 invoked by uid 89); 19 Feb 2020 20:09:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 20:09:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582142973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=79frL84GHdTvcqLfydW4nf3OSWHHYIsfm9b3TmWjKz8=; b=S8eUmEhl3YPVAuTuTNcdOvitBU8zomo41sdIEH5jLf2kFV4piqZ6R+gkz7yAbLkEvGi535 NDjkw5EuDqxmJfm59aRWsoOfXIEhNBXkpMvz5aBr5cKap1qwf5HNu6WqJUOw4qDN8lZgHq 5YBtzdhSVI5tLY9wKMAlvNd1w/0Pub4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-xRTzKK8LMp6hYVIuKCsAxA-1; Wed, 19 Feb 2020 15:09:32 -0500 Received: by mail-wr1-f71.google.com with SMTP id t6so637029wru.3 for ; Wed, 19 Feb 2020 12:09:31 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c4sm1260170wml.7.2020.02.19.12.09.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2020 12:09:29 -0800 (PST) Subject: Re: [PATCH][gdb/testsuite] Fix corefile-buildid.exp with check-read1 To: Tom de Vries , gdb-patches@sourceware.org References: <20200219174014.GA28126@delia> From: Pedro Alves Message-ID: <851a18b0-b172-4b59-e411-ce3379c95c76@redhat.com> Date: Wed, 19 Feb 2020 20:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200219174014.GA28126@delia> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00793.txt.bz2 On 2/19/20 5:40 PM, Tom de Vries wrote: > Hi, > > When running gdb.base/corefile-buildid.exp using check-read1, I run into: > ... > FAIL: gdb.base/corefile-buildid.exp: shared: info files (timeout) > FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files (timeout) > FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files (timeout) > FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files \ > (timeout) > ... > > This is caused by attempting to match the output of an "info files" command > using a single gdb_test in check_exec_file. > > Fix this by doing line-by-line matching in check_exec_file. > > Tested on x86_64-linux, using make targets check and check-read1. > > OK for trunk? OK. If this pattern appears in more places it may be worth it to think about some abstraction to make it easier to write. Like e.g., a new "-lbl" (line-by-line) option switch to gdb_test_multiple that auto-appends the "match one line" regexp. Thanks, Pedro Alves