From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/8] Add support for $_siginfo on FreeBSD
Date: Thu, 06 Jul 2017 13:29:00 -0000 [thread overview]
Message-ID: <84d46774-6f5d-3934-2640-890d819edc83@redhat.com> (raw)
In-Reply-To: <86c318b0-91ea-58b6-8a4e-b3da39e3504e@FreeBSD.org>
On 07/06/2017 12:17 PM, John Baldwin wrote:
> On 6/29/17 7:32 PM, John Baldwin wrote:
>> This series adds support for $_siginfo for both live processes and
>> process cores. siginfo_t for threads is only stored in a per-thread
>> ELF core note on FreeBSD 12.0 and later.
>>
>> The existing code in corelow.c for siginfo_t assumed the Linux-specific
>> NT_SIGINFO ELF core note, but FreeBSD stores siginfo as one member of a
>> larger ELF core note. To accomodate this, I added a new gdbarch method
>> that is used to fetch the signal information from a core dump. I moved
>> the body of the existing core_get_siginfo function into an implementation
>> of the new gdbarch method in linux-tdep.c.
>>
>> Tested on FreeBSD/amd64 (64-bit and 32-bit binaries), FreeBSD/i386,
>> and Centos/x86-64 (no regressions in test suite for this last).
>
> Ping? The binutils patches (6 and 7) have been approved, but some of the
> GDB patches (3 and 4) are not FreeBSD-specific (e.g. a new gdbarch method
> for fetching siginfo from a core).
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-07-06 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 23:33 John Baldwin
2017-06-29 23:33 ` [PATCH 2/8] Fetch signal information for native FreeBSD processes John Baldwin
2017-06-29 23:33 ` [PATCH 8/8] Read signal information from FreeBSD core dumps John Baldwin
2017-06-29 23:33 ` [PATCH 6/8] Recognize the recently-added FreeBSD core dump note for LWP info John Baldwin
2017-06-30 3:19 ` Alan Modra
2017-06-29 23:33 ` [PATCH 7/8] Create psuedo sections for FreeBSD NT_PTLWPINFO core notes John Baldwin
2017-06-30 3:20 ` Alan Modra
2017-06-29 23:33 ` [PATCH 3/8] Move the thread_section_name class to gdbcore.h John Baldwin
2017-06-29 23:33 ` [PATCH 1/8] Implement the "get_siginfo_type" gdbarch method for FreeBSD architectures John Baldwin
2017-06-29 23:41 ` [PATCH 4/8] Add a new gdbarch method to fetch signal information from core files John Baldwin
2017-06-29 23:41 ` [PATCH 5/8] Use the thread_section_name helper class in fbsd_core_thread_name John Baldwin
2017-07-06 11:17 ` [PATCH 0/8] Add support for $_siginfo on FreeBSD John Baldwin
2017-07-06 13:29 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d46774-6f5d-3934-2640-890d819edc83@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox