From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19124 invoked by alias); 6 Jul 2017 13:29:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18977 invoked by uid 89); 6 Jul 2017 13:29:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1108 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Jul 2017 13:29:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDEF44E03F; Thu, 6 Jul 2017 13:29:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DDEF44E03F Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DDEF44E03F Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A05260A9D; Thu, 6 Jul 2017 13:29:38 +0000 (UTC) Subject: Re: [PATCH 0/8] Add support for $_siginfo on FreeBSD To: John Baldwin , gdb-patches@sourceware.org References: <20170629233226.20155-1-jhb@FreeBSD.org> <86c318b0-91ea-58b6-8a4e-b3da39e3504e@FreeBSD.org> From: Pedro Alves Message-ID: <84d46774-6f5d-3934-2640-890d819edc83@redhat.com> Date: Thu, 06 Jul 2017 13:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86c318b0-91ea-58b6-8a4e-b3da39e3504e@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00038.txt.bz2 On 07/06/2017 12:17 PM, John Baldwin wrote: > On 6/29/17 7:32 PM, John Baldwin wrote: >> This series adds support for $_siginfo for both live processes and >> process cores. siginfo_t for threads is only stored in a per-thread >> ELF core note on FreeBSD 12.0 and later. >> >> The existing code in corelow.c for siginfo_t assumed the Linux-specific >> NT_SIGINFO ELF core note, but FreeBSD stores siginfo as one member of a >> larger ELF core note. To accomodate this, I added a new gdbarch method >> that is used to fetch the signal information from a core dump. I moved >> the body of the existing core_get_siginfo function into an implementation >> of the new gdbarch method in linux-tdep.c. >> >> Tested on FreeBSD/amd64 (64-bit and 32-bit binaries), FreeBSD/i386, >> and Centos/x86-64 (no regressions in test suite for this last). > > Ping? The binutils patches (6 and 7) have been approved, but some of the > GDB patches (3 and 4) are not FreeBSD-specific (e.g. a new gdbarch method > for fetching siginfo from a core). LGTM. Thanks, Pedro Alves