Re: [PATCH 0/8] Add support for $_siginfo on FreeBSD

Pedro Alves
2017-07-06T13:29:45Z

On 07/06/2017 12:17 PM, John Baldwin wrote:
> On 6/29/17 7:32 PM, John Baldwin wrote:
>> This series adds support for $_siginfo for both live processes and
>> process cores. siginfo_t for threads is only stored in a per-thread
>> ELF core note on FreeBSD 12.0 and later.
>>
>> The existing code in corelow.c for siginfo_t assumed the Linux-specific
>> NT_SIGINFO ELF core note, but FreeBSD stores siginfo as one member of a
>> larger ELF core note. To accomodate this, I added a new gdbarch method
>> that is used to fetch the signal information from a core dump. I moved
>> the body of the existing core_get_siginfo function into an implementation
>> of the new gdbarch method in linux-tdep.c.
>>
>> Tested on FreeBSD/amd64 (64-bit and 32-bit binaries), FreeBSD/i386,
>> and Centos/x86-64 (no regressions in test suite for this last).
>
> Ping? The binutils patches (6 and 7) have been approved, but some of the
> GDB patches (3 and 4) are not FreeBSD-specific (e.g. a new gdbarch method
> for fetching siginfo from a core).

LGTM.

Thanks,
Pedro Alves