From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc
Date: Wed, 12 Apr 2017 19:14:00 -0000 [thread overview]
Message-ID: <83zifligku.fsf@gnu.org> (raw)
In-Reply-To: <20170412180610.2565-1-simon.marchi@ericsson.com> (message from Simon Marchi on Wed, 12 Apr 2017 14:06:09 -0400)
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@ericsson.com>
> Date: Wed, 12 Apr 2017 14:06:09 -0400
>
> The MI documentation says that -thread-info output contains a "current"
> field in the current thread tuple, with the value "*". Current GDB
> master does not do this, and I couldn't find any GDB version that did.
> I suspect that it was never the case.
>
> The code that would correspond to this in print_thread_info_1 is
> essentially dead code. The calls to uiout->text end up in
> mi_out::do_text, which is empty.
>
> This patch removes the documentation bit and the dead code. This
> "current" field is not necessary, since -thread-info outputs a
> "current-thread-id" field.
>
> gdb/ChangeLog:
>
> * thread.c (print_thread_info_1): Remove dead code.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
> from -thread-info output.
OK for the documentation part.
Thanks.
prev parent reply other threads:[~2017-04-12 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 18:06 Simon Marchi
2017-04-12 18:07 ` [PATCH 2/2] doc: Improve documentation about MI thread output Simon Marchi
2017-04-12 18:17 ` Simon Marchi
2017-04-12 19:18 ` Eli Zaretskii
2017-04-12 19:26 ` Simon Marchi
2017-04-12 19:32 ` Eli Zaretskii
2017-04-12 20:10 ` Simon Marchi
2017-04-12 20:34 ` Eli Zaretskii
2017-04-12 21:13 ` Simon Marchi
2017-04-13 6:02 ` Eli Zaretskii
2017-04-22 1:57 ` Simon Marchi
2017-04-12 19:14 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zifligku.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox