From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60148 invoked by alias); 12 Apr 2017 19:14:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60126 invoked by uid 89); 12 Apr 2017 19:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=essentially X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 19:14:24 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyNif-0000PK-08 for gdb-patches@sourceware.org; Wed, 12 Apr 2017 15:14:24 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyNie-0000PG-Si; Wed, 12 Apr 2017 15:14:20 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1130 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyNic-00068g-5N; Wed, 12 Apr 2017 15:14:20 -0400 Date: Wed, 12 Apr 2017 19:14:00 -0000 Message-Id: <83zifligku.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <20170412180610.2565-1-simon.marchi@ericsson.com> (message from Simon Marchi on Wed, 12 Apr 2017 14:06:09 -0400) Subject: Re: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc Reply-to: Eli Zaretskii References: <20170412180610.2565-1-simon.marchi@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00363.txt.bz2 > From: Simon Marchi > CC: Simon Marchi > Date: Wed, 12 Apr 2017 14:06:09 -0400 > > The MI documentation says that -thread-info output contains a "current" > field in the current thread tuple, with the value "*". Current GDB > master does not do this, and I couldn't find any GDB version that did. > I suspect that it was never the case. > > The code that would correspond to this in print_thread_info_1 is > essentially dead code. The calls to uiout->text end up in > mi_out::do_text, which is empty. > > This patch removes the documentation bit and the dead code. This > "current" field is not necessary, since -thread-info outputs a > "current-thread-id" field. > > gdb/ChangeLog: > > * thread.c (print_thread_info_1): Remove dead code. > > gdb/doc/ChangeLog: > > * gdb.texinfo (GDB/MI Thread Commands): Remove "current" field > from -thread-info output. OK for the documentation part. Thanks.