Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] doc: Improve documentation about MI thread output
Date: Wed, 12 Apr 2017 19:26:00 -0000	[thread overview]
Message-ID: <c623e3bf-d40a-7353-44d0-4f82eb6b6ecb@ericsson.com> (raw)
In-Reply-To: <83y3v5igdx.fsf@gnu.org>

On 17-04-12 03:18 PM, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@ericsson.com>
>> CC: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Wed, 12 Apr 2017 14:06:10 -0400
>>
>> I noticed that the documentation on how the info about threads is output
>> in MI is duplicated and not up to date.  The duplication is between the
>> "GDB/MI Thread Information" page and the -thread-info result
>> description.
>>
>> I improved the "GDB/MI Thread Information" page a bit and referred to it
>> in the -thread-info doc.  This way, the -thread-info doc is more precise
>> (it did not mention the "threads" and "current-thread-id" attributes)
>> and concise.
> 
> Thanks.  This is okay, with a couple of minor gotchas:
> 
>> +@item current-thread-id
>> +The global id of the current selected thread.  This field is only present if
>                         ^^^^^^^
> "currently"

Ok.

>> +there is a selected thread and no @var{thread-id} argument was passed to the
> 
> How can there not be a selected thread?

When the currently selected inferior is not running.  The obvious case is the initial
state of gdb.  But it's also possible to have threads but none is selected, for example
when you add a second inferior and switch to it, while the first inferior is running.

The field is output if inferior_ptid != null_ptid, so maybe there are other situations
I am not aware of where there isn't a current thread.

>> +command..
> 
> One extra period at end of sentence.

Ok.

Thanks,

Simon


  reply	other threads:[~2017-04-12 19:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 18:06 [PATCH 1/2] Remove dead code and "current" field from MI thread output doc Simon Marchi
2017-04-12 18:07 ` [PATCH 2/2] doc: Improve documentation about MI thread output Simon Marchi
2017-04-12 18:17   ` Simon Marchi
2017-04-12 19:18   ` Eli Zaretskii
2017-04-12 19:26     ` Simon Marchi [this message]
2017-04-12 19:32       ` Eli Zaretskii
2017-04-12 20:10         ` Simon Marchi
2017-04-12 20:34           ` Eli Zaretskii
2017-04-12 21:13             ` Simon Marchi
2017-04-13  6:02               ` Eli Zaretskii
2017-04-22  1:57                 ` Simon Marchi
2017-04-12 19:14 ` [PATCH 1/2] Remove dead code and "current" field from MI thread output doc Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c623e3bf-d40a-7353-44d0-4f82eb6b6ecb@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox