Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/Ada] Update comment on how to "fix" dynamic entities
Date: Fri, 27 Nov 2009 09:05:00 -0000	[thread overview]
Message-ID: <83vdgwmj77.fsf@gnu.org> (raw)
In-Reply-To: <20091127015211.GC18125@adacore.com>

> Date: Thu, 26 Nov 2009 17:52:12 -0800
> From: Joel Brobecker <brobecker@adacore.com>
> 
> This is a pure documentation that we have had in our tree for a while,
> and I had meant to contribute it ealier, but forgot. Hopefully, it helps
> understanding the whole decoding thing a little more - it's really
> complex, sometimes.
> 
> 2009-11-26  Joel Brobecker  <brobecker@adacore.com>
> 
>         * ada-lang.c: Update the comment explaining how to evaluate
>         Ada expressions.

Why on Earth is this only in the sources?  It cannot be found there
easily, unless I already know it's there.

How about placing a copy of this in gdbint.texinfo, where it could be
indexed, cross-referenced, etc.?

> +    Arrays are a little simpler to handle than records, because the same
> +    amount of memory is allocated for each element of the array, even if
> +    the amount of space actually used by each element changes from element
> +    to element.                                       ^^^^^^^

"differs", not "changes".  "Change" is a dynamic thing, meaning it can
change on the fly, and I don't believe you mean that.

> +    The actual amount of memory occupied by each element might change
                                                                  ^^^^^^
"differ" or "be different".

> +    But the amount of space reserved for each element in the array remains
> +    constant regardless.  So we simply need to compute that size using
       ^^^^^^^^
Suggest to use "fixed" instead.

> +    In some cases, the size of allocated for each element is statically
                               ^^
That "of" looks like it need to be removed.

Thanks.


  reply	other threads:[~2009-11-27  9:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27  1:52 Joel Brobecker
2009-11-27  9:05 ` Eli Zaretskii [this message]
2009-11-27 15:34   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vdgwmj77.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox