From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/Ada] Update comment on how to "fix" dynamic entities
Date: Fri, 27 Nov 2009 15:34:00 -0000 [thread overview]
Message-ID: <20091127153435.GE18125@adacore.com> (raw)
In-Reply-To: <83vdgwmj77.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
Thanks for the corrections, they are always very appreciated.
I applied them as follow.
2009-11-27 Joel Brobecker <brobecker@adacore.com>
* ada-lang.c: Apply some corrections to the previous comment addition.
--
Joel
[-- Attachment #2: ada-comment-update.diff --]
[-- Type: text/x-diff, Size: 1885 bytes --]
Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.235
diff -u -p -r1.235 ada-lang.c
--- ada-lang.c 27 Nov 2009 01:49:41 -0000 1.235
+++ ada-lang.c 27 Nov 2009 15:31:38 -0000
@@ -8480,15 +8480,15 @@ ada_value_cast (struct type *type, struc
Arrays are a little simpler to handle than records, because the same
amount of memory is allocated for each element of the array, even if
- the amount of space actually used by each element changes from element
+ the amount of space actually used by each element differs from element
to element. Consider for instance the following array of type Rec:
type Rec_Array is array (1 .. 2) of Rec;
- The actual amount of memory occupied by each element might change
- from element to element, depending on the their discriminant value.
+ The actual amount of memory occupied by each element might be different
+ from element to element, depending on the value of their discriminant.
But the amount of space reserved for each element in the array remains
- constant regardless. So we simply need to compute that size using
+ fixed regardless. So we simply need to compute that size using
the debugging information available, from which we can then determine
the array size (we multiply the number of elements of the array by
the size of each element).
@@ -8512,7 +8512,7 @@ ada_value_cast (struct type *type, struc
that we also use the adjective "aligner" in our code to designate
these wrapper types.
- In some cases, the size of allocated for each element is statically
+ In some cases, the size allocated for each element is statically
known. In that case, the PAD type already has the correct size,
and the array element should remain unfixed.
prev parent reply other threads:[~2009-11-27 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 1:52 Joel Brobecker
2009-11-27 9:05 ` Eli Zaretskii
2009-11-27 15:34 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127153435.GE18125@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox