From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26305 invoked by alias); 27 Nov 2009 09:05:29 -0000 Received: (qmail 26296 invoked by uid 22791); 27 Nov 2009 09:05:28 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_20,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Nov 2009 09:05:17 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KTR00C00EK4H900@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 27 Nov 2009 11:05:09 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KTR00AYFFWJXJ80@a-mtaout20.012.net.il>; Fri, 27 Nov 2009 11:05:08 +0200 (IST) Date: Fri, 27 Nov 2009 09:05:00 -0000 From: Eli Zaretskii Subject: Re: [commit/Ada] Update comment on how to "fix" dynamic entities In-reply-to: <20091127015211.GC18125@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83vdgwmj77.fsf@gnu.org> References: <20091127015211.GC18125@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00582.txt.bz2 > Date: Thu, 26 Nov 2009 17:52:12 -0800 > From: Joel Brobecker > > This is a pure documentation that we have had in our tree for a while, > and I had meant to contribute it ealier, but forgot. Hopefully, it helps > understanding the whole decoding thing a little more - it's really > complex, sometimes. > > 2009-11-26 Joel Brobecker > > * ada-lang.c: Update the comment explaining how to evaluate > Ada expressions. Why on Earth is this only in the sources? It cannot be found there easily, unless I already know it's there. How about placing a copy of this in gdbint.texinfo, where it could be indexed, cross-referenced, etc.? > + Arrays are a little simpler to handle than records, because the same > + amount of memory is allocated for each element of the array, even if > + the amount of space actually used by each element changes from element > + to element. ^^^^^^^ "differs", not "changes". "Change" is a dynamic thing, meaning it can change on the fly, and I don't believe you mean that. > + The actual amount of memory occupied by each element might change ^^^^^^ "differ" or "be different". > + But the amount of space reserved for each element in the array remains > + constant regardless. So we simply need to compute that size using ^^^^^^^^ Suggest to use "fixed" instead. > + In some cases, the size of allocated for each element is statically ^^ That "of" looks like it need to be removed. Thanks.