From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] python: Add qualified parameter to gdb.Breakpoint
Date: Fri, 08 Dec 2017 19:47:00 -0000 [thread overview]
Message-ID: <83tvx1uhmd.fsf@gnu.org> (raw)
In-Reply-To: <015c4c07-8a85-e54d-1179-497bf3203175@ericsson.com> (message from Simon Marchi on Fri, 8 Dec 2017 13:26:48 -0500)
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Fri, 8 Dec 2017 13:26:48 -0500
>
> > OK for the documentation part. (Do we need a NEWS entry?)
>
> A NEWS entry would be good. I think we can complement the existing one about
> -qualified instead of making a new one. What about this?
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index c6fe297..bd5ae36 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -81,7 +81,9 @@
> GDB interpret the specified function name as a complete
> fully-qualified name instead. For example, using the same C++
> program, the "break -q B::func" command sets a breakpoint on
> - "B::func", only.
> + "B::func", only. A parameter has been added to the Python
> + gdb.Breakpoint constructor to achieve the same result when creating
> + a breakpoint from Python.
>
> * Breakpoints on functions marked with C++ ABI tags
Fine with me, thanks.
prev parent reply other threads:[~2017-12-08 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 22:34 Simon Marchi
2017-12-08 12:05 ` Pedro Alves
2017-12-08 18:42 ` Simon Marchi
2017-12-13 13:17 ` Pedro Alves
2017-12-13 16:45 ` Simon Marchi
2017-12-08 14:15 ` Eli Zaretskii
2017-12-08 18:27 ` Simon Marchi
2017-12-08 19:47 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvx1uhmd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox