From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112494 invoked by alias); 8 Dec 2017 19:47:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112483 invoked by uid 89); 8 Dec 2017 19:47:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 19:47:49 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNOca-000406-Fh for gdb-patches@sourceware.org; Fri, 08 Dec 2017 14:47:47 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNOca-0003zt-Bp; Fri, 08 Dec 2017 14:47:44 -0500 Received: from [176.228.60.248] (port=3534 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNOcZ-0006bi-7t; Fri, 08 Dec 2017 14:47:44 -0500 Date: Fri, 08 Dec 2017 19:47:00 -0000 Message-Id: <83tvx1uhmd.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <015c4c07-8a85-e54d-1179-497bf3203175@ericsson.com> (message from Simon Marchi on Fri, 8 Dec 2017 13:26:48 -0500) Subject: Re: [PATCH] python: Add qualified parameter to gdb.Breakpoint Reply-to: Eli Zaretskii References: <1512686013-24658-1-git-send-email-simon.marchi@ericsson.com> <83efo5wbke.fsf@gnu.org> <015c4c07-8a85-e54d-1179-497bf3203175@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00198.txt.bz2 > From: Simon Marchi > Date: Fri, 8 Dec 2017 13:26:48 -0500 > > > OK for the documentation part. (Do we need a NEWS entry?) > > A NEWS entry would be good. I think we can complement the existing one about > -qualified instead of making a new one. What about this? > > diff --git a/gdb/NEWS b/gdb/NEWS > index c6fe297..bd5ae36 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -81,7 +81,9 @@ > GDB interpret the specified function name as a complete > fully-qualified name instead. For example, using the same C++ > program, the "break -q B::func" command sets a breakpoint on > - "B::func", only. > + "B::func", only. A parameter has been added to the Python > + gdb.Breakpoint constructor to achieve the same result when creating > + a breakpoint from Python. > > * Breakpoints on functions marked with C++ ABI tags Fine with me, thanks.