From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Implement debugging of WOW64 processes in gdbserver
Date: Wed, 29 Apr 2020 18:16:37 +0300 [thread overview]
Message-ID: <83tv12xqy2.fsf@gnu.org> (raw)
In-Reply-To: <a777ea78-48d6-b295-6292-fcf50584df5a@simark.ca> (message from Simon Marchi on Wed, 29 Apr 2020 11:09:08 -0400)
> From: Simon Marchi <simark@simark.ca>
> Date: Wed, 29 Apr 2020 11:09:08 -0400
>
> > These functions are not available on WinXP, and the extra check for them
> > was actually the reason of this v2:
> >
> > + if (wow64_process
> > + && (win32_Wow64SuspendThread == nullptr
> > + || win32_Wow64GetThreadContext == nullptr
> > + || win32_Wow64SetThreadContext == nullptr))
> > + error ("WOW64 debugging is not supported on this system.\n");
>
> Ok, please add a comment to that effect then. This way if we decide we no longer want
> to support Windows XP, we can remove this in favor of just calling the functions directly.
Do the functions exist on 32-bit Windows systems newer than XP? The
documentation says:
It is not supported on 32-bit Windows; such calls fail and set the
last error code to ERROR_INVALID_FUNCTION.
I'm not sure what this means for calling these functions directly.
next prev parent reply other threads:[~2020-04-29 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427133416.9314-1-ssbssa.ref@yahoo.de>
2020-04-27 13:34 ` Hannes Domani
2020-04-28 15:53 ` Simon Marchi
2020-04-29 10:54 ` Hannes Domani
2020-04-29 15:09 ` Simon Marchi
2020-04-29 15:16 ` Eli Zaretskii [this message]
2020-04-29 15:28 ` Simon Marchi
2020-04-29 16:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tv12xqy2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox