From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 9744C38930CB
 for <gdb-patches@sourceware.org>; Wed, 29 Apr 2020 15:17:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9744C38930CB
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57087)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jToSN-0006bg-Ux; Wed, 29 Apr 2020 11:17:04 -0400
Received: from [176.228.60.248] (port=2696 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jToSM-0008EK-S3; Wed, 29 Apr 2020 11:17:03 -0400
Date: Wed, 29 Apr 2020 18:16:37 +0300
Message-Id: <83tv12xqy2.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org
In-Reply-To: <a777ea78-48d6-b295-6292-fcf50584df5a@simark.ca> (message from
 Simon Marchi on Wed, 29 Apr 2020 11:09:08 -0400)
Subject: Re: [PATCH v2] Implement debugging of WOW64 processes in gdbserver
References: <20200427133416.9314-1-ssbssa.ref@yahoo.de>
 <20200427133416.9314-1-ssbssa@yahoo.de>
 <7ec0c0b7-5425-d766-326b-9d5b13b755b4@simark.ca>
 <471105047.4011567.1588157665165@mail.yahoo.com>
 <a777ea78-48d6-b295-6292-fcf50584df5a@simark.ca>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, BODY_8BITS,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2020 15:17:05 -0000

> From: Simon Marchi <simark@simark.ca>
> Date: Wed, 29 Apr 2020 11:09:08 -0400
> 
> > These functions are not available on WinXP, and the extra check for them
> > was actually the reason of this v2:
> > 
> > +  if (wow64_process
> > +      && (win32_Wow64SuspendThread == nullptr
> > +      || win32_Wow64GetThreadContext == nullptr
> > +      || win32_Wow64SetThreadContext == nullptr))
> > +    error ("WOW64 debugging is not supported on this system.\n");
> 
> Ok, please add a comment to that effect then.  This way if we decide we no longer want
> to support Windows XP, we can remove this in favor of just calling the functions directly.

Do the functions exist on 32-bit Windows systems newer than XP?  The
documentation says:

  It is not supported on 32-bit Windows; such calls fail and set the
  last error code to ERROR_INVALID_FUNCTION.

I'm not sure what this means for calling these functions directly.