Re: [PATCH v2] Implement debugging of WOW64 processes in gdbserver

[Simon Marchi <simark@simark.ca>]

On 2020-04-29 6:54 a.m., Hannes Domani via Gdb-patches wrote:
>> Since this is copied from gdb/windows-nat.c, it would be nice to factor it
>> out (as well as the small snippet below), so it can be shared.  Otherwise,
>> if we make a fix to one, we'll most likely forget to fix the other.
>>
>> The shared versions would go into gdb/nat/windows-nat.c.
> 
> There might be even more code that can be shared now, I planned to do this
> with a later patch.

Ok.

>> Why do we need to get these functions like this, instead of just calling them?
> 
> These functions are not available on WinXP, and the extra check for them
> was actually the reason of this v2:
> 
> +  if (wow64_process
> +      && (win32_Wow64SuspendThread == nullptr
> +      || win32_Wow64GetThreadContext == nullptr
> +      || win32_Wow64SetThreadContext == nullptr))
> +    error ("WOW64 debugging is not supported on this system.\n");

Ok, please add a comment to that effect then.  This way if we decide we no longer want
to support Windows XP, we can remove this in favor of just calling the functions directly.

Simon