From: Eli Zaretskii <eliz@gnu.org>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Add a new modifier /c to "disassemble" command to make it output binary code
Date: Thu, 09 Jul 2009 19:53:00 -0000 [thread overview]
Message-ID: <83skh5y7ru.fsf@gnu.org> (raw)
In-Reply-To: <daef60380907082335j78b9ae35jaf552124a65022a3@mail.gmail.com>
> Date: Thu, 9 Jul 2009 14:35:54 +0800
> From: Hui Zhu <teawater@gmail.com>
>
> +With a /c modifier, binary code are included.\n\
I think you mean "hex dump of machine code", not "binary code". In
any case, "binary code is included", in singular, not plural.
> -@itemx disassemble /m
> +@itemx disassemble /mc
Isn't it better to show that the modifiers are independent? Like
this:
@item disassemble
@itemx disassemble /m
@itemx disassemble /c
> -the @code{/m} modifier.
> +the @code{/m} modifier and print binary code by specifying
> +the @code{/c}.
Again, I think "machine code in hex dump format" is better.
Okay with these changes.
next prev parent reply other threads:[~2009-07-09 19:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 12:22 Hui Zhu
2009-07-09 19:22 ` Tom Tromey
2009-07-09 19:40 ` Eli Zaretskii
2009-07-11 9:28 ` Hui Zhu
2009-07-11 12:42 ` Eli Zaretskii
2009-07-11 14:15 ` Hui Zhu
2009-07-11 17:54 ` Eli Zaretskii
2009-07-11 17:59 ` Hui Zhu
2009-07-11 18:16 ` Regression for mi-disassemble.exp [Re: Add a new modifier /c to "disassemble" command to make it output binary code] Jan Kratochvil
2009-07-17 17:09 ` [commit] Fix mi-disassemble.exp regression Ulrich Weigand
2009-07-18 5:45 ` Hui Zhu
2009-07-09 19:53 ` Eli Zaretskii [this message]
2009-07-09 22:00 ` Add a new modifier /c to "disassemble" command to make it output binary code Michael Snyder
2009-07-09 23:44 ` Doug Evans
2009-07-10 9:33 ` Eli Zaretskii
2009-07-10 14:34 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83skh5y7ru.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox