Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: jan.kratochvil@redhat.com (Jan Kratochvil)
Cc: teawater@gmail.com (Hui Zhu), eliz@gnu.org (Eli Zaretskii),
	        tromey@redhat.com, msnyder@vmware.com, dje@google.com,
	        mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: [commit] Fix mi-disassemble.exp regression
Date: Fri, 17 Jul 2009 17:09:00 -0000	[thread overview]
Message-ID: <200907171559.n6HFxHTx013069@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090711175407.GA18892@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at Jul 11, 2009 07:54:07 PM

Jan Kratochvil wrote:

> On Sat, 11 Jul 2009 16:15:00 +0200, Hui Zhu wrote:
> > Fixed and checked-in.
> 
> this check-in
> 	http://sourceware.org/ml/gdb-cvs/2009-07/msg00089.html
> 	http://sourceware.org/ml/gdb-cvs/2009-07/msg00092.html
[snip]
> causes a regression on {x86_64,x86_64-32,i686}-fedora11-linux-gnu.

This is caused by this part of Hui's patch:

--- a/mi/mi-cmd-disas.c
+++ b/mi/mi-cmd-disas.c
@@ -156,6 +156,6 @@ mi_cmd_disassemble (char *command, char

   gdb_disassembly (gdbarch, uiout,
   		   file_string,
-		   mixed_source_and_assembly, how_many, low, high);
+		   DISASSEMBLY_SOURCE, how_many, low, high);

 }

Note how the new code completely ignores the mixed_source_and_assembly
flag (which is set from the mixed_mode MI parameter).

The following patch fixes this.
Tested on powerpc64-linux, committed to mainline.

Bye,
Ulrich

ChangeLog:

	* mi/mi-cmd-disas.c (mi_cmd_disassemble): Respect mixed_mode flag.

Index: gdb/mi/mi-cmd-disas.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-cmd-disas.c,v
retrieving revision 1.31
diff -u -p -r1.31 mi-cmd-disas.c
--- gdb/mi/mi-cmd-disas.c	11 Jul 2009 14:04:23 -0000	1.31
+++ gdb/mi/mi-cmd-disas.c	17 Jul 2009 15:50:06 -0000
@@ -156,6 +156,6 @@ mi_cmd_disassemble (char *command, char 
 
   gdb_disassembly (gdbarch, uiout,
   		   file_string,
-		   DISASSEMBLY_SOURCE, how_many, low, high);
-
+		   mixed_source_and_assembly? DISASSEMBLY_SOURCE : 0,
+		   how_many, low, high);
 }


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2009-07-17 15:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 12:22 Add a new modifier /c to "disassemble" command to make it output binary code Hui Zhu
2009-07-09 19:22 ` Tom Tromey
2009-07-09 19:40   ` Eli Zaretskii
2009-07-11  9:28   ` Hui Zhu
2009-07-11 12:42     ` Eli Zaretskii
2009-07-11 14:15       ` Hui Zhu
2009-07-11 17:54         ` Eli Zaretskii
2009-07-11 17:59           ` Hui Zhu
2009-07-11 18:16             ` Regression for mi-disassemble.exp [Re: Add a new modifier /c to "disassemble" command to make it output binary code] Jan Kratochvil
2009-07-17 17:09               ` Ulrich Weigand [this message]
2009-07-18  5:45                 ` [commit] Fix mi-disassemble.exp regression Hui Zhu
2009-07-09 19:53 ` Add a new modifier /c to "disassemble" command to make it output binary code Eli Zaretskii
2009-07-09 22:00 ` Michael Snyder
2009-07-09 23:44 ` Doug Evans
2009-07-10  9:33   ` Eli Zaretskii
2009-07-10 14:34   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907171559.n6HFxHTx013069@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox