From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65314-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18515 invoked by alias); 9 Jul 2009 19:29:52 -0000
Received: (qmail 18507 invoked by uid 22791); 9 Jul 2009 19:29:51 -0000
X-SWARE-Spam-Status: No, hits=0.4 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jul 2009 19:29:44 +0000
Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KMJ00K004OQ9500@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Thu, 09 Jul 2009 22:29:40 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.126.249.41]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KMJ00C3B4TFBED0@i-mtaout7.012.net.il>; Thu, 09 Jul 2009 22:29:40 +0300 (IDT)
Date: Thu, 09 Jul 2009 19:53:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Add a new modifier /c to "disassemble" command to make it output	binary code
In-reply-to: <daef60380907082335j78b9ae35jaf552124a65022a3@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83skh5y7ru.fsf@gnu.org>
References: <daef60380907082335j78b9ae35jaf552124a65022a3@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00293.txt.bz2

> Date: Thu, 9 Jul 2009 14:35:54 +0800
> From: Hui Zhu <teawater@gmail.com>
> 
> +With a /c modifier, binary code are included.\n\

I think you mean "hex dump of machine code", not "binary code".  In
any case, "binary code is included", in singular, not plural.

> -@itemx disassemble /m
> +@itemx disassemble /mc

Isn't it better to show that the modifiers are independent?  Like
this:

 @item disassemble
 @itemx disassemble /m
 @itemx disassemble /c


> -the @code{/m} modifier.
> +the @code{/m} modifier and print binary code by specifying
> +the @code{/c}.

Again, I think "machine code in hex dump format" is better.

Okay with these changes.