Re: [PATCHv2 4/4] gdb: Add new commands to list module variables and functions

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu,  3 Oct 2019 12:29:17 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2347c14d37d..d92ab2d6e20 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -142,6 +142,20 @@ info modules [-q] [REGEXP]
>    Return a list of Fortran modules matching REGEXP, or all modules if
>    no REGEXP is given.
>  
> +info module functions [-q] [-m MODULE_REGEXP] [-t TYPE_REGEXP] [REGEXP]
> +  Return a list of functions within all modules, grouped by module.
> +  The list of functions can be restricted with the optional regular
> +  expressions.  MODULE_REGEXP matches against the module name,
> +  TYPE_REGEXP matches against the function type signature, and REGEXP
> +  matches against the function name.
> +
> +info module variables [-q] [-m MODULE_REGEXP] [-t TYPE_REGEXP] [REGEXP]
> +  Return a list of variables within all modules, grouped by module.
> +  The list of variables can be restricted with the optional regular
> +  expressions.  MODULE_REGEXP matches against the module name,
> +  TYPE_REGEXP matches against the variable type, and REGEXP matches
> +  against the variable name.

This part is OK.

> +@kindex info module functions
> +@kindex info module variables
> +@cindex modules
> +@cindex functions
> +@cindex variables
> +@cindex module functions
> +@cindex module variables

It is not useful to have several index entries which all begin with
the same string and point to the same place.  I suggest to have just
these:

  +@kindex info module
  +@cindex Fortran modules, information about
  +@cindex functions and variables by Fortran module
  +@cindex module functions and variables

> +@item info module functions [-q] [-m @var{module-regexp}] [-t @var{type-regexp}] [@var{regexp}]
> +@item info module variables [-q] [-m @var{module-regexp}] [-t @var{type-regexp}] [@var{regexp}]

The second one should be @itemx.

The patch for the manual is OK with these nits fixed.

Thanks.