From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2802 invoked by alias); 3 Oct 2019 16:16:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2794 invoked by uid 89); 3 Oct 2019 16:16:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 16:16:32 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iG3mH-0002ue-GF; Thu, 03 Oct 2019 12:16:29 -0400 Received: from [176.228.60.248] (port=2734 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iG3mG-0004i1-TN; Thu, 03 Oct 2019 12:16:29 -0400 Date: Thu, 03 Oct 2019 16:16:00 -0000 Message-Id: <83sgo97qk1.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess CC: gdb-patches@sourceware.org In-reply-to: <2572574a445f9f32b4cca9a6f767d8495f4503c1.1570101531.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Thu, 3 Oct 2019 12:29:17 +0100) Subject: Re: [PATCHv2 4/4] gdb: Add new commands to list module variables and functions References: <2572574a445f9f32b4cca9a6f767d8495f4503c1.1570101531.git.andrew.burgess@embecosm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00117.txt.bz2 > From: Andrew Burgess > Cc: Andrew Burgess > Date: Thu, 3 Oct 2019 12:29:17 +0100 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 2347c14d37d..d92ab2d6e20 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -142,6 +142,20 @@ info modules [-q] [REGEXP] > Return a list of Fortran modules matching REGEXP, or all modules if > no REGEXP is given. > > +info module functions [-q] [-m MODULE_REGEXP] [-t TYPE_REGEXP] [REGEXP] > + Return a list of functions within all modules, grouped by module. > + The list of functions can be restricted with the optional regular > + expressions. MODULE_REGEXP matches against the module name, > + TYPE_REGEXP matches against the function type signature, and REGEXP > + matches against the function name. > + > +info module variables [-q] [-m MODULE_REGEXP] [-t TYPE_REGEXP] [REGEXP] > + Return a list of variables within all modules, grouped by module. > + The list of variables can be restricted with the optional regular > + expressions. MODULE_REGEXP matches against the module name, > + TYPE_REGEXP matches against the variable type, and REGEXP matches > + against the variable name. This part is OK. > +@kindex info module functions > +@kindex info module variables > +@cindex modules > +@cindex functions > +@cindex variables > +@cindex module functions > +@cindex module variables It is not useful to have several index entries which all begin with the same string and point to the same place. I suggest to have just these: +@kindex info module +@cindex Fortran modules, information about +@cindex functions and variables by Fortran module +@cindex module functions and variables > +@item info module functions [-q] [-m @var{module-regexp}] [-t @var{type-regexp}] [@var{regexp}] > +@item info module variables [-q] [-m @var{module-regexp}] [-t @var{type-regexp}] [@var{regexp}] The second one should be @itemx. The patch for the manual is OK with these nits fixed. Thanks.