Re: [PATCHv2 4/4] gdb: Add new commands to list module variables and functions

[Tom de Vries <tdevries@suse.de>]

On 03-10-2019 13:29, Andrew Burgess wrote:
> 	* gdb.fortran/info-modules.exp: Update expected results, and add
> 	additional tests for 'info module functinos', and 'info module
> 	variables'.
> 	* gdb.fortran/info-types.exp: Update expected results.
> 	* gdb.fortran/info-types.f90: Extend testcase with additional
> 	module variables and functions.

Hi,

This test-case fails to compile for me:
...
$ cd build/gdb; make check RUNTESTFLAGS="gdb.fortran/info-modules.exp"
gdb compile failed, src/gdb/testsuite/gdb.fortran/info-types.f90:39:6:

   use mod2
      1
Fatal Error: Can't open module file 'mod2.mod' for reading at (1): No
such file or directory
compilation terminated.

                === gdb Summary ===

# of untested testcases         1
...

Interestingly, if I first run:
...
$ cd build/gdb; make check RUNTESTFLAGS="gdb.fortran/module.exp"
Running src/gdb/testsuite/gdb.fortran/module.exp ...

                === gdb Summary ===

# of expected passes            27
...
which produces:
...
$ ls -la build/gdb/testsuite/mod2.mod
-rw-r--r-- 1 vries users 208 22 nov 13:35 build/gdb/testsuite/mod2.mod
...
then the test-case passes:
...
$ cd build/gdb; make check RUNTESTFLAGS="gdb.fortran/info-modules.exp"
Running src/gdb/testsuite/gdb.fortran/info-modules.exp ...

                === gdb Summary ===

# of expected passes            12
...

Removing mod2.mod brings the failure back:
...
$ rm -f build/gdb/testsuite/mod2.mod
             $ cd build/gdb; make check
RUNTESTFLAGS="gdb.fortran/info-modules.exp"
gdb compile failed, src/gdb/testsuite/gdb.fortran/info-types.f90:39:6:

   use mod2
      1
Fatal Error: Can't open module file 'mod2.mod' for reading at (1): No
such file or directory
compilation terminated.

                === gdb Summary ===

# of untested testcases         1
...

So, I think that in a parallel test run this may succeed, but in a
sequential testrun this should fail.

Thanks,
- Tom