Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] gdb/doc: clarify the language for the '?' packet
Date: Mon, 07 Dec 2020 17:55:55 +0200	[thread overview]
Message-ID: <83sg8h8vas.fsf@gnu.org> (raw)
In-Reply-To: <20201207135319.31884-1-alex.bennee@linaro.org> (message from Alex =?utf-8?Q?Benn=C3=A9e?= via Gdb-patches on Mon, 7 Dec 2020 13:53:19 +0000)

> Date: Mon,  7 Dec 2020 13:53:19 +0000
> From: Alex Bennée via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> 
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -39273,9 +39273,9 @@ The remote target both supports and has enabled extended mode.
>  
>  @item ?
>  @cindex @samp{?} packet
> -@anchor{? packet}
> -Indicate the reason the target halted.  The reply is the same as for
> -step and continue.  This packet has a special interpretation when the
> +@anchor{? packet} Is a query sent when connection is first established
> +to query the reason the target halted. The reply is the same as for
> +step and continue. This packet has a special interpretation when the
>  target is in non-stop mode; see @ref{Remote Non-Stop}.

Minor comments:

  . please make the @anchor be a separate line, as it was before
  . the first sentence ("Is a query sent...") sounds awkward, suggest
    to reword "This is sent when connection is first ..."
  . please make sure to leave 2 spaces between sentences, per our
    conventions
  . please provide a suitable log message and ChangeLog change

Thanks.

      parent reply	other threads:[~2020-12-07 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 13:53 Alex Bennée via Gdb-patches
2020-12-07 14:36 ` Luis Machado via Gdb-patches
2020-12-07 15:55 ` Eli Zaretskii via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sg8h8vas.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=alex.bennee@linaro.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox