From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] gdb/doc: clarify the language for the '?' packet
Date: Mon, 7 Dec 2020 11:36:42 -0300 [thread overview]
Message-ID: <ce617d93-7620-7bb1-cda7-520fcd712f11@linaro.org> (raw)
In-Reply-To: <20201207135319.31884-1-alex.bennee@linaro.org>
On 12/7/20 10:53 AM, Alex Bennée via Gdb-patches wrote:
> Both QEMU and kgdb make the assumption that the '?' packet is only
> sent during the initial setup of a gdbstub connection. Both use that
> knowledge to reset breakpoints and ensure the gdbstub is in a
> clean-state on a resumed connection. This can cause confusion for
> others implementing clients that speak to gdbstub devices. To avoid
> that make the language clearer that this is a start-up query packet
> that you only expect to see once.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> gdb/doc/gdb.texinfo | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 8bff27c940d..f5b6fdd8691 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -39273,9 +39273,9 @@ The remote target both supports and has enabled extended mode.
>
> @item ?
> @cindex @samp{?} packet
> -@anchor{? packet}
> -Indicate the reason the target halted. The reply is the same as for
> -step and continue. This packet has a special interpretation when the
> +@anchor{? packet} Is a query sent when connection is first established
> +to query the reason the target halted. The reply is the same as for
More like "to query the status of the target". To see if it is running,
stopped etc...
With that clarification, I think this looks good. Others may have more
feedback.
It is important to mention this is a very old packet with a historically
vague description, but I think it is safe to say GDB doesn't have a
reason to send it more than once per remote session.
next prev parent reply other threads:[~2020-12-07 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 13:53 Alex Bennée via Gdb-patches
2020-12-07 14:36 ` Luis Machado via Gdb-patches [this message]
2020-12-07 15:55 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce617d93-7620-7bb1-cda7-520fcd712f11@linaro.org \
--to=gdb-patches@sourceware.org \
--cc=alex.bennee@linaro.org \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox