From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id N58mAJ5Qzl9RSAAAWB0awg (envelope-from ) for ; Mon, 07 Dec 2020 10:56:14 -0500 Received: by simark.ca (Postfix, from userid 112) id EAEDD1F096; Mon, 7 Dec 2020 10:56:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 30B531E552 for ; Mon, 7 Dec 2020 10:56:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D03A9389682C; Mon, 7 Dec 2020 15:56:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D03A9389682C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607356572; bh=a9UHhEtwvbVP5w+KhECMmlO9/dP/afErAmUdYq3fUFQ=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fPU2sTZwWRXkNafazYNLlsW14LFZLRq51oD+0hHKe6+0Lq1P9mG9VLtoSXaFbp9Qk Qt6DeVE+Zr6JVcTLPE3tDP/dlqJWNOv7YJRASKzN/jth6O/zjJ5fI/u9+Dv+VKB5MU oqnUT+218Ems/Vt1PiWNnO5ZLmiHjn7QqaMeXiNI= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 010533894C35 for ; Mon, 7 Dec 2020 15:56:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 010533894C35 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57776) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmIrt-0006vZ-EQ; Mon, 07 Dec 2020 10:56:05 -0500 Received: from [176.228.60.248] (port=2177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmIrr-0008PV-W6; Mon, 07 Dec 2020 10:56:04 -0500 Date: Mon, 07 Dec 2020 17:55:55 +0200 Message-Id: <83sg8h8vas.fsf@gnu.org> To: Alex =?utf-8?Q?Benn=C3=A9e?= In-Reply-To: <20201207135319.31884-1-alex.bennee@linaro.org> (message from Alex =?utf-8?Q?Benn=C3=A9e?= via Gdb-patches on Mon, 7 Dec 2020 13:53:19 +0000) Subject: Re: [RFC PATCH] gdb/doc: clarify the language for the '?' packet References: <20201207135319.31884-1-alex.bennee@linaro.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Date: Mon, 7 Dec 2020 13:53:19 +0000 > From: Alex Bennée via Gdb-patches > Cc: Alex Bennée > > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -39273,9 +39273,9 @@ The remote target both supports and has enabled extended mode. > > @item ? > @cindex @samp{?} packet > -@anchor{? packet} > -Indicate the reason the target halted. The reply is the same as for > -step and continue. This packet has a special interpretation when the > +@anchor{? packet} Is a query sent when connection is first established > +to query the reason the target halted. The reply is the same as for > +step and continue. This packet has a special interpretation when the > target is in non-stop mode; see @ref{Remote Non-Stop}. Minor comments: . please make the @anchor be a separate line, as it was before . the first sentence ("Is a query sent...") sounds awkward, suggest to reword "This is sent when connection is first ..." . please make sure to leave 2 spaces between sentences, per our conventions . please provide a suitable log message and ChangeLog change Thanks.