From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Require extern modifier for function prototypes in headers.
Date: Wed, 19 Dec 2012 16:58:00 -0000 [thread overview]
Message-ID: <83r4mmnfm7.fsf@gnu.org> (raw)
In-Reply-To: <000001cddddb$7999a0a0$6ccce1e0$%muller@ics-cnrs.unistra.fr>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 19 Dec 2012 12:24:56 +0100
>
> All external functions should have a declaration in a header file that
> -callers include, except for @code{_initialize_*} functions, which must
> +callers include, that declaration should use the @code{extern} modifier.
> +The only exception concerns @code{_initialize_*} functions, which must
> be external so that @file{init.c} construction works, but shouldn't be
> visible to random source files.
If all declarations must be external, the _initialize_* case is no
longer special, so the second sentence should go away, IMO.
Otherwise, OK with me.
Thanks.
next parent reply other threads:[~2012-12-19 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000001cddddb$7999a0a0$6ccce1e0$%muller@ics-cnrs.unistra.fr>
2012-12-19 16:58 ` Eli Zaretskii [this message]
2012-12-19 21:48 ` Pierre Muller
2012-12-19 11:25 ` Pierre Muller
2012-12-22 12:54 ` Jan Kratochvil
2012-12-22 17:53 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r4mmnfm7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox